mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Wanlong Gao <wanlong.gao@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [Doc] class_find_device: fix reference to argument
Date: Mon, 22 Aug 2011 17:48:39 -0700	[thread overview]
Message-ID: <20110823004839.GA29215@kroah.com> (raw)
In-Reply-To: <20110821145355.94fb7923.rdunlap@xenotime.net>

On Sun, Aug 21, 2011 at 02:53:55PM -0700, Randy Dunlap wrote:
> On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
> 
> > Rolf Eike Beer <eike <at> sf-mail.de> writes:
> > 
> > > 
> > > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> > > ---
> > >  drivers/base/class.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > 
> > > - * @fn is allowed to do anything including calling back into class
> > > + * @match is allowed to do anything including calling back into class
> > >   * code.  There's no locking restriction.
> > >   */
> > >  struct device *class_find_device(struct class *class, struct device *start,
> > 
> > NACK, it means the function class_find_device but not the @match.
> 
> Are you sure?  Looks to me like a comment that was copied from
> class_for_each_device() but shouldn't have been copied.
> 
> Anyway, I'll cc: Greg to see if he knows.

I think the above patch is probably correct, as it can reenter if
needed.

thanks,

greg k-h

  reply	other threads:[~2011-08-23  0:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-21 10:56 [Doc] class_find_device: fix reference to argument "match" Rolf Eike Beer
2011-08-21 14:46 ` [Doc] class_find_device: fix reference to argument Wanlong Gao
2011-08-21 21:53   ` Randy Dunlap
2011-08-23  0:48     ` Greg KH [this message]
2011-08-22  8:29 Wanlong Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823004839.GA29215@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=wanlong.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®