From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218Ab1HWJUs (ORCPT ); Tue, 23 Aug 2011 05:20:48 -0400 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:43958 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755094Ab1HWJUp (ORCPT ); Tue, 23 Aug 2011 05:20:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnkDAHZtU055LIxDgWdsb2JhbABBqCQVAQEWJiWBQAEBBTocIxAIAw4HAy4UJQMhE78iDoY6BKQl Date: Tue, 23 Aug 2011 19:20:41 +1000 From: Dave Chinner To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, khlebnikov@openvz.org Subject: Re: [PATCH 01/13] fs: Use a common define for inode slab caches Message-ID: <20110823092041.GX3162@dastard> References: <1314089786-20535-1-git-send-email-david@fromorbit.com> <1314089786-20535-2-git-send-email-david@fromorbit.com> <20110823091307.GA21492@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110823091307.GA21492@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2011 at 05:13:07AM -0400, Christoph Hellwig wrote: > On Tue, Aug 23, 2011 at 06:56:14PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > All inode slab cache initialisation calls need to use specific flags > > so that certain core functionality works correctly (e.g. reclaimable > > memory accounting). Some of these flags are used inconsistently > > across different filesystems, so inode cache slab behaviour can vary > > according to filesystem type. > > > > Wrap all the SLAB_* flags relevant to inode caches up into a single > > SLAB_INODES flag and convert all the inode caches to use the new > > flag. > > Why do we keep the SLAB_HWCACHE_ALIGN flag for some filesystems? I didn't touch that one, mainly because I think that there are different reasons for wanting cacheline alignment. e.g. a filesystem aimed primarily at embedded systms with slow CPUs and little memory doesn't want to waste memory on cacheline alignment.... Cheers, Dave. -- Dave Chinner david@fromorbit.com