mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Felipe Balbi <balbi@ti.com>, Greg KH <greg@kroah.com>
Subject: Re: linux-next: build failure after merge of the moduleh tree
Date: Tue, 23 Aug 2011 12:59:40 +0300	[thread overview]
Message-ID: <20110823095938.GJ1341@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20110823150854.2f6da7f66247c3d31b07e072@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

Hi,

On Tue, Aug 23, 2011 at 03:08:54PM +1000, Stephen Rothwell wrote:
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/usb/dwc3/dwc3-pci.c: In function 'dwc3_pci_init':
> drivers/usb/dwc3/dwc3-pci.c:211:9: error: 'THIS_MODULE' undeclared (first use in this function)
> 
> Caused by the interaction of the module.h split up with commit
> 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver") from the usb
> tree.
> 
> I have applied this patch for today (Greg, this should be applied to your
> tree):
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 23 Aug 2011 15:05:25 +1000
> Subject: [PATCH] usb: include module.h in the DesignWare USB3 DRD driver
> 
> Fixes this build error:
> 
> drivers/usb/dwc3/dwc3-pci.c: In function 'dwc3_pci_init':
> drivers/usb/dwc3/dwc3-pci.c:211:9: error: 'THIS_MODULE' undeclared (first use in this function)
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/usb/dwc3/dwc3-pci.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
> index 2578595..e3b77d2 100644
> --- a/drivers/usb/dwc3/dwc3-pci.c
> +++ b/drivers/usb/dwc3/dwc3-pci.c
> @@ -38,6 +38,7 @@
>   */
>  
>  #include <linux/kernel.h>
> +#include <linux/module.h>

that was my fault, I didn't know about Paul's commit. Please Greg, apply
this to your tree:

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-08-23  9:59 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23  5:08 Stephen Rothwell
2011-08-23  9:59 ` Felipe Balbi [this message]
2011-09-02 18:32   ` Geert Uytterhoeven
2011-09-05 10:39     ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2012-03-23  4:51 Stephen Rothwell
2012-03-23 12:49 ` Paul Gortmaker
2012-03-23 13:03   ` Stephen Rothwell
2011-11-01  7:38 Stephen Rothwell
2011-10-12  6:29 Stephen Rothwell
2011-10-11  8:39 Stephen Rothwell
2011-10-11  8:25 Stephen Rothwell
2011-10-11 13:05 ` Mark Brown
2011-10-04  7:32 Stephen Rothwell
2011-10-04  7:21 Stephen Rothwell
2011-10-04 15:24 ` Jonathan Cameron
2011-10-04  7:11 Stephen Rothwell
2011-10-04  7:03 Stephen Rothwell
2011-10-04  7:35 ` Kalle Valo
2011-10-04  8:14   ` Stephen Rothwell
2011-10-04 15:09     ` Larry Finger
2011-09-30  4:50 Stephen Rothwell
2011-09-30 12:52 ` Linus Walleij
2011-09-30 13:19   ` Stephen Rothwell
2011-10-03  6:55     ` Linus Walleij
2011-09-30 18:56 ` Paul Gortmaker
2011-09-28  8:41 Stephen Rothwell
2011-09-28 13:42 ` Paul Gortmaker
2011-09-29  0:15   ` Paul Gortmaker
2011-09-29  1:15     ` Stephen Rothwell
2011-09-28  8:35 Stephen Rothwell
2011-09-28 16:42 ` Kalle Valo
2011-09-28  8:25 Stephen Rothwell
2011-09-28  8:18 Stephen Rothwell
2011-10-09  5:08 ` Paul Gortmaker
2011-10-09 18:01   ` Chris Ball
2011-09-28  8:00 Stephen Rothwell
2011-09-28  7:50 Stephen Rothwell
2011-09-28  7:42 Stephen Rothwell
2011-09-28  7:58 ` Borislav Petkov
2011-09-28  7:10 Stephen Rothwell
2011-08-10  1:49 Stephen Rothwell
2011-08-03  4:16 Stephen Rothwell
2011-08-03 14:26 ` Greg KH
2011-08-03  4:10 Stephen Rothwell
2011-08-02  5:13 Stephen Rothwell
2011-08-02 10:15 ` Alasdair G Kergon
2011-08-01  3:58 Stephen Rothwell
2011-07-29  7:09 Stephen Rothwell
2011-07-31  6:59 ` Paul Gortmaker
2011-07-29  7:06 Stephen Rothwell
2011-07-31  7:44 ` Paul Gortmaker
2011-08-01  0:30   ` Stephen Rothwell
2011-07-29  6:48 Stephen Rothwell
2011-07-31  7:30 ` Paul Gortmaker
2011-07-29  6:24 Stephen Rothwell
2011-07-31  7:26 ` Paul Gortmaker
2011-07-29  6:19 Stephen Rothwell
2011-07-31  8:08 ` Paul Gortmaker
2011-07-29  5:41 Stephen Rothwell
2011-07-29  5:30 Stephen Rothwell
2011-07-29  5:25 Stephen Rothwell
2011-07-29  5:37 ` Stephen Rothwell
2011-07-31  6:31   ` Paul Gortmaker
2011-07-31  8:14 ` Paul Gortmaker
2011-07-29  5:10 Stephen Rothwell
2011-07-30 19:03 ` Dmitry Torokhov
2011-07-29  5:10 Stephen Rothwell
2011-07-31  4:45 ` Paul Gortmaker
2011-07-29  4:56 Stephen Rothwell
2011-07-31  5:44 ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823095938.GJ1341@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®