mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Akshay Joshi <me@akshayjoshi.com>
Cc: Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@suse.de>,
	Pekka Enberg <penberg@kernel.org>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.
Date: Tue, 23 Aug 2011 15:27:38 -0700	[thread overview]
Message-ID: <20110823222738.GE15721@kroah.com> (raw)
In-Reply-To: <1313454275-5604-1-git-send-email-me@akshayjoshi.com>

On Mon, Aug 15, 2011 at 08:24:27PM -0400, Akshay Joshi wrote:
> Split the case statement and the code that is executed if the condition
> is met so that it passes checkpatch.pl and conforms to the kernel code
> style.

Not quite.

Please put the 'break;' on a new line for every case statement.

Care to redo this whole series based on the review comments you got so
far and resend them?

thanks,

greg k-h

      parent reply	other threads:[~2011-08-23 22:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16  0:24 Akshay Joshi
2011-08-16  0:24 ` [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c Akshay Joshi
2011-08-16  5:41   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 3/9] Staging: Winbond: Fix space issues " Akshay Joshi
2011-08-16  5:42   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond Akshay Joshi
2011-08-16  5:42   ` Pekka Enberg
2011-08-16 19:56   ` Gábor Stefanik
2011-08-16 21:24     ` Pekka Enberg
2011-08-16 21:38       ` Gábor Stefanik
2011-08-16 21:40         ` Gábor Stefanik
2011-08-17  5:41         ` Pekka Enberg
2011-08-17 19:15           ` Akshay Joshi
2011-08-17 19:17             ` Akshay Joshi
2011-08-17 21:08               ` Dan Carpenter
2011-08-16 21:43       ` Dan Carpenter
2011-08-17  0:19         ` Akshay Joshi
2011-08-16  0:24 ` [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs Akshay Joshi
2011-08-16  5:43   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers Akshay Joshi
2011-08-16  5:45   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 7/9] Staging: Winbond: Fix parentheses in returns Akshay Joshi
2011-08-16  5:45   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents Akshay Joshi
2011-08-16  5:46   ` Pekka Enberg
2011-08-16  0:24 ` [PATCH 9/9] Staging: Winbond: Reposition a curly bracket Akshay Joshi
2011-08-16  5:46   ` Pekka Enberg
2011-08-16  5:41 ` [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Pekka Enberg
2011-08-23 22:27 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823222738.GE15721@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=imirkin@alum.mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@akshayjoshi.com \
    --cc=pavel@ucw.cz \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome