From: Alasdair G Kergon <agk@redhat.com>
To: dm-devel@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] dm-kcopyd: Correctly free requests
Date: Fri, 26 Aug 2011 11:43:37 +0100 [thread overview]
Message-ID: <20110826104337.GN31980@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20110826103747.GA15125@agk-dp.fab.redhat.com>
On Fri, Aug 26, 2011 at 11:37:47AM +0100, Alasdair G Kergon wrote:
> On Fri, Aug 26, 2011 at 12:15:42PM +0200, Bastian Blank wrote:
> > kcopyd only frees the requests if the master job information is set up
> > correctly, but it was not in the recently added path. This leads to many
> > unfreed slabs during snapshot usage.
> Referring to commit c6ea41fbbe08f270a8edef99dc369faf809d1bd6
> dm kcopyd: preallocate sub jobs to avoid deadlock
> which added the master_job field.
and commit a6e50b409d3f9e0833e69c3c9cca822e8fa4adbb
dm snapshot: skip reading origin when overwriting complete chunk
which indeed forgets to set the new field.
I'll submit the patch shortly, together with some other minor fixes
sitting in linux-next.
Alasdair
prev parent reply other threads:[~2011-08-26 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 10:15 Bastian Blank
2011-08-26 10:37 ` [dm-devel] " Alasdair G Kergon
2011-08-26 10:43 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826104337.GN31980@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®