From: Andrew Morton <akpm@linux-foundation.org>
To: jhbird.choi@samsung.com
Cc: linux-kernel@vger.kernel.org, Donggeun Kim <dg77.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] driver/misc/fsa9480.c fix potential null-pointer dereference
Date: Fri, 26 Aug 2011 17:18:49 -0700 [thread overview]
Message-ID: <20110826171849.4f488908.akpm@linux-foundation.org> (raw)
In-Reply-To: <1311668375-24131-1-git-send-email-jhbird.choi@samsung.com>
On Tue, 26 Jul 2011 17:19:35 +0900
jhbird.choi@samsung.com wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/misc/fsa9480.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/fsa9480.c b/drivers/misc/fsa9480.c
> index 5325a7e..0bd1e5b 100644
> --- a/drivers/misc/fsa9480.c
> +++ b/drivers/misc/fsa9480.c
> @@ -400,7 +400,8 @@ static int fsa9480_irq_init(struct fsa9480_usbsw *usbsw)
> return ret;
> }
>
> - device_init_wakeup(&client->dev, pdata->wakeup);
> + if (pdata)
> + device_init_wakeup(&client->dev, pdata->wakeup);
> }
>
> return 0;
So i2c_client.dev.platform_data was NULL. Is this an allowed state?
What would cause this?
prev parent reply other threads:[~2011-08-27 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 8:19 jhbird.choi
2011-08-27 0:18 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826171849.4f488908.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dg77.kim@samsung.com \
--cc=jhbird.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®