From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: stable-review@kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
632923@bugs.debian.org, Ben Hutchings <ben@decadent.org.uk>,
Christian Ohm <chr.ohm@gmx.net>, Ingo Molnar <mingo@elte.hu>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jonathan Nieder <jrnieder@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [10/20] perf tools: do not look at ./config for configuration
Date: Fri, 26 Aug 2011 15:03:33 -0700 [thread overview]
Message-ID: <20110826220419.862176019@clark.kroah.org> (raw)
In-Reply-To: <20110826220431.GA15382@kroah.com>
2.6.33-longterm review patch. If anyone has any objections, please let us know.
------------------
From: Jonathan Nieder <jrnieder@gmail.com>
commit aba8d056078e47350d85b06a9cabd5afcc4b72ea upstream.
In addition to /etc/perfconfig and $HOME/.perfconfig, perf looks for
configuration in the file ./config, imitating git which looks at
$GIT_DIR/config. If ./config is not a perf configuration file, it
fails, or worse, treats it as a configuration file and changes behavior
in some unexpected way.
"config" is not an unusual name for a file to be lying around and perf
does not have a private directory dedicated for its own use, so let's
just stop looking for configuration in the cwd. Callers needing
context-sensitive configuration can use the PERF_CONFIG environment
variable.
Requested-by: Christian Ohm <chr.ohm@gmx.net>
Cc: 632923@bugs.debian.org
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Christian Ohm <chr.ohm@gmx.net>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20110805165838.GA7237@elie.gateway.2wire.net
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
tools/perf/util/config.c | 7 -------
1 file changed, 7 deletions(-)
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -416,7 +416,6 @@ int perf_config_global(void)
int perf_config(config_fn_t fn, void *data)
{
int ret = 0, found = 0;
- char *repo_config = NULL;
const char *home = NULL;
/* Setting $PERF_CONFIG makes perf read _only_ the given config file. */
@@ -438,12 +437,6 @@ int perf_config(config_fn_t fn, void *da
free(user_config);
}
- repo_config = perf_pathdup("config");
- if (!access(repo_config, R_OK)) {
- ret += perf_config_from_file(fn, repo_config, data);
- found += 1;
- }
- free(repo_config);
if (found == 0)
return -1;
return ret;
next prev parent reply other threads:[~2011-08-27 15:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 22:04 [00/20] 2.6.33.19-longterm review Greg KH
2011-08-26 22:03 ` [01/20] staging: rtl8192u: declare MODULE_FIRMWARE Greg KH
2011-08-26 22:03 ` [02/20] USB: xhci: fix OS want to own HC Greg KH
2011-08-26 22:03 ` [03/20] USB: assign instead of equal in usbtmc.c Greg KH
2011-08-26 22:03 ` [04/20] USB: usb-storage: unusual_devs entry for ARM V2M motherboard Greg KH
2011-08-26 22:03 ` [05/20] USB: Serial: Added device ID for Qualcomm Modem in Sagemcom's HiLo3G Greg KH
2011-08-26 22:03 ` [06/20] atm: br2864: sent packets truncated in VC routed mode Greg KH
2011-08-26 22:03 ` [07/20] hwmon: (ibmaem) add missing kfree Greg KH
2011-08-26 22:03 ` [08/20] ALSA: snd-usb-caiaq: Correct offset fields of outbound iso_frame_desc Greg KH
2011-08-26 22:03 ` [09/20] mm: fix wrong vmap address calculations with odd NR_CPUS values Greg KH
2011-08-26 22:03 ` Greg KH [this message]
2011-08-26 22:03 ` [11/20] fs/partitions/efi.c: corrupted GUID partition tables can cause kernel oops Greg KH
2011-08-26 22:03 ` [12/20] befs: Validate length of long symbolic links Greg KH
2011-08-26 22:03 ` [13/20] ALSA: snd_usb_caiaq: track submitted output urbs Greg KH
2011-08-26 22:03 ` [14/20] ALSA: ac97: Add HP Compaq dc5100 SFF(PT003AW) to Headphone Jack Sense whitelist Greg KH
2011-08-26 22:03 ` [15/20] futex: Fix regression with read only mappings Greg KH
2011-08-26 22:03 ` [16/20] x86-32, vdso: On system call restart after SYSENTER, use int $0x80 Greg KH
2011-08-26 22:03 ` [17/20] x86, UV: Remove UV delay in starting slave cpus Greg KH
2011-08-26 22:03 ` [18/20] drm/ttm: fix ttm_bo_add_ttm(user) failure path Greg KH
2011-08-26 22:03 ` [19/20] fuse: check size of FUSE_NOTIFY_INVAL_ENTRY message Greg KH
2011-08-26 22:03 ` [20/20] igb: Fix lack of flush after register write and before delay Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826220419.862176019@clark.kroah.org \
--to=gregkh@suse.de \
--cc=632923@bugs.debian.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben@decadent.org.uk \
--cc=chr.ohm@gmx.net \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=stable-review@kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®