From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406Ab1H2XLW (ORCPT ); Mon, 29 Aug 2011 19:11:22 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52509 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323Ab1H2XLU convert rfc822-to-8bit (ORCPT ); Mon, 29 Aug 2011 19:11:20 -0400 Date: Mon, 29 Aug 2011 16:10:15 -0700 From: Stephen Hemminger To: Dmitry Torokhov Cc: Jonathan =?ISO-8859-1?B?TmV1c2No5GZlcg==?= , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH trivial] input: apanel: remove a redundant MODULE_ALIAS Message-ID: <20110829161015.323c20a3@nehalam.ftrdhcpuser.net> In-Reply-To: <201108291507.14497.dmitry.torokhov@gmail.com> References: <1314653189-31020-1-git-send-email-j.neuschaefer@gmx.net> <201108291507.14497.dmitry.torokhov@gmail.com> Organization: Linux Foundation X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Aug 2011 15:07:14 -0700 Dmitry Torokhov wrote: > On Monday, August 29, 2011 02:26:29 PM Jonathan Neuschäfer wrote: > > Signed-off-by: Jonathan Neuschäfer > > --- > > drivers/input/misc/apanel.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/input/misc/apanel.c b/drivers/input/misc/apanel.c > > index a8d2b8d..1dd1bd3 100644 > > --- a/drivers/input/misc/apanel.c > > +++ b/drivers/input/misc/apanel.c > > @@ -346,5 +346,4 @@ MODULE_DESCRIPTION(APANEL_NAME " driver"); > > MODULE_LICENSE("GPL"); > > MODULE_VERSION(APANEL_VERSION); > > > > -MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifeBook*:pvr*:rvnFUJITSU:*"); > > MODULE_ALIAS("dmi:*:svnFUJITSU:pnLifebook*:pvr*:rvnFUJITSU:*"); > ^ > > Not necessarily redundant, if you notice the register is different. > At one point I found machines with both values, that is why there are two entries.