From: Manohar Vanga <manohar.vanga@cern.ch>
To: "Emilio G. Cota" <cota@braap.org>
Cc: <gregkh@suse.de>, <martyn.welch@ge.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support
Date: Tue, 30 Aug 2011 12:39:29 +0200 [thread overview]
Message-ID: <20110830103929.GA8814@becoht-mvanga> (raw)
In-Reply-To: <20110829145543.GA9952@flamenco.cs.columbia.edu>
> Here there seems to be a missing kfree(vdev), like the one after device_unregister()
> a few lines earlier.
> > + if (!err & (drv->ndev == 0))
>
> Probably you meant if (!err && drv->ndev == 0) here.
Ah darn. Will fix and resend.
> In fact one could imagine a driver that has no devices when it's
> installed (it might get them later); so I'd remove this check.
Yeah I suppose with VME64x it's possible. Will remove.
--
/manohar
next prev parent reply other threads:[~2011-08-30 10:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 9:02 [PATCH 0/3] [RESEND v3] VME Driver Changes Manohar Vanga
2011-08-29 9:02 ` [PATCH 1/3] staging: vme: add functions for bridge module refcounting Manohar Vanga
2011-08-29 14:56 ` Emilio G. Cota
2011-08-29 17:51 ` Greg KH
2011-08-29 18:40 ` Emilio G. Cota
2011-08-29 18:54 ` Greg KH
2011-08-29 9:02 ` [PATCH 2/3] staging: vme: add struct vme_dev for VME devices Manohar Vanga
2011-08-29 14:57 ` Emilio G. Cota
2011-08-29 17:52 ` Greg KH
2011-08-29 23:55 ` Emilio G. Cota
2011-08-30 7:52 ` Manohar Vanga
2011-08-29 9:02 ` [PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support Manohar Vanga
2011-08-29 14:55 ` Emilio G. Cota
2011-08-30 10:39 ` Manohar Vanga [this message]
2011-08-31 10:05 [PATCH 0/3] [RESEND v4] VME Framework Fixes Manohar Vanga
2011-08-31 10:05 ` [PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support Manohar Vanga
2011-08-31 21:20 ` Emilio G. Cota
2011-09-01 7:46 ` Manohar Vanga
2011-09-01 9:15 [PATCH 0/3] [RESEND v5] VME Framework Fixes Manohar Vanga
2011-09-01 9:15 ` [PATCH 3/3] staging: vme: make match() driver specific to improve non-VME64x support Manohar Vanga
2011-09-01 22:26 ` Emilio G. Cota
2011-09-26 14:16 ` Manohar Vanga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830103929.GA8814@becoht-mvanga \
--to=manohar.vanga@cern.ch \
--cc=cota@braap.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®