From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754977Ab1HaCkv (ORCPT ); Tue, 30 Aug 2011 22:40:51 -0400 Received: from tx2ehsobe001.messaging.microsoft.com ([65.55.88.11]:8992 "EHLO TX2EHSOBE001.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754853Ab1HaCks (ORCPT ); Tue, 30 Aug 2011 22:40:48 -0400 X-SpamScore: -17 X-BigFish: VS-17(zz14e0M9371K1432N98dKzz1202hzzz2dh2a8h668h839h944h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPVD:NLI;H:mail.freescale.net;RD:none;EFVD:NLI Date: Wed, 31 Aug 2011 10:49:30 +0800 From: Shawn Guo To: Stephen Warren CC: Grant Likely , Chris Ball , "devicetree-discuss@lists.ozlabs.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] sdhci/tegra: Add Device Tree probing support Message-ID: <20110831024929.GA19795@S2100-06.ap.freescale.net> References: <1314123334-23133-1-git-send-email-swarren@nvidia.com> <20110830034035.GC19294@S2100-06.ap.freescale.net> <74CDBE0F657A3D45AFBB94109FB122FF04B3279D3F@HQMAIL01.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04B3279D3F@HQMAIL01.nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2011 at 09:01:37AM -0700, Stephen Warren wrote: > Shawn Guo wrote at Monday, August 29, 2011 9:41 PM: > > On Tue, Aug 23, 2011 at 12:15:33PM -0600, Stephen Warren wrote: > > > From: Grant Likely > > > > > > Add hooks to read gpio configuration out of the device tree node. > ... > > > diff --git a/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia-sdhci.txt > ... > > > +* NVIDIA Tegra Secure Digital Host Controller > > > + > > > +This controller on Tegra family SoCs provides an interface for MMC, SD, > > > +and SDIO types of memory cards. > > > + > > > +Required properties: > > > +- compatible : Should be "nvidia,-sdhci" > > > +- reg : Should contain eSDHC registers location and length > > > +- interrupts : Should contain eSDHC interrupt > > > > You may want to replace eSDHC with something Tegra specific. > > True. The patch is already submitted. Do you think it's worth posting one > just to fix that; It's totally your call. Regards, Shawn > it still seems pretty clear what's required? >