From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Earl Chew <echew@ixiacom.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<viro@zeniv.linux.org.uk>, <andi@firstfloor.org>,
<oleg@redhat.com>
Subject: Re: [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm
Date: Thu, 1 Sep 2011 19:55:54 +0100 [thread overview]
Message-ID: <20110901195554.667c5e58@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4E5FBA73.2050108@ixiacom.com>
On Thu, 1 Sep 2011 10:01:39 -0700
Earl Chew <echew@ixiacom.com> wrote:
> Change corepattern %e and %E to use current->group_leader->comm instead of current->comm.
Which might break stuff.
> A core dump can be triggered from any task in a group, and substituting current->comm
> means that the name of the core file for a process can vary in surprising ways.
Which some people may well be using
> Using current->group_leader->comm makes the name of the core file more consistent
> for a process when used with %e or %E.
In your view, but there is a better way to do this - add a new case and
letter for the behaviour you want. That way you don't break anyone elses
defaults and expectation and people can set a corepattern dependant upon
the group leader.
Alan
next prev parent reply other threads:[~2011-09-01 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:01 Earl Chew
2011-09-01 18:55 ` Alan Cox [this message]
2011-09-01 19:12 ` [PATCH 1/1 v2]: " Earl Chew
2011-09-02 16:30 ` Oleg Nesterov
2011-09-02 17:09 ` Earl Chew
2011-09-02 17:48 ` Oleg Nesterov
2011-09-02 23:05 ` Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901195554.667c5e58@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=echew@ixiacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®