From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300Ab1IBQJf (ORCPT ); Fri, 2 Sep 2011 12:09:35 -0400 Received: from out4.smtp.messagingengine.com ([66.111.4.28]:49411 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208Ab1IBQJa (ORCPT ); Fri, 2 Sep 2011 12:09:30 -0400 X-Sasl-enc: C4RQxTxQUmZLm8ilae4Oj5e5O0MjcIk5cCi01P4SQrR2 1314979769 Date: Fri, 2 Sep 2011 09:09:24 -0700 From: Greg KH To: "K. Y. Srinivasan" Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org Subject: Re: Hyper-V TODO file Message-ID: <20110902160924.GA4784@kroah.com> References: <1314829011-28922-1-git-send-email-kys@microsoft.com> <20110901202733.GA15185@kroah.com> <20110901203031.GB15185@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110901203031.GB15185@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 01, 2011 at 01:30:31PM -0700, Greg KH wrote: > On Thu, Sep 01, 2011 at 01:27:33PM -0700, Greg KH wrote: > > On Wed, Aug 31, 2011 at 03:16:51PM -0700, K. Y. Srinivasan wrote: > > > 2) With your help, we have fixed all of the issues related to these drivers > > > conforming to the Linux Device Driver model. One of the TODO work items is > > > "audit the vmbus to verify it is working properly with the driver model". > > > > I have a few comments about this, I'll respond in another email. > > Ok, it looks a _lot_ better, but I have a few minor nits, and one larger > one: Oh, here's another issue I forgot about. You can get rid of the 'ext' field of the hv_device structure and use the proper function in the driver core for this type of thing, just wrap it up in your own function to make it "sane" looking, like USB and PCI does with their usb_get_intfdata(), usb_set_intfdata(), pci_get_drvdata(), and pci_set_drvdata() functions. thanks, greg k-h