From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Baruch Siach <baruch@tkos.co.il>,
Andrew Morton <akpm@linux-foundation.org>,
kernel@pengutronix.de, Arnd Bergmann <arnd@arndb.de>
Subject: including <linux/workqueue.h> isn't self contained
Date: Tue, 6 Sep 2011 20:29:28 +0200 [thread overview]
Message-ID: <20110906182928.GJ28816@pengutronix.de> (raw)
Hello,
compiling drivers/rtc/rtc-imxdi.c currently results in:
drivers/rtc/rtc-imxdi.c: In function 'di_write_wait':
drivers/rtc/rtc-imxdi.c:168:301: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
drivers/rtc/rtc-imxdi.c:168:301: note: each undeclared identifier is reported only once for each function it appears in
drivers/rtc/rtc-imxdi.c:168:2: error: implicit declaration of function 'signal_pending'
drivers/rtc/rtc-imxdi.c:168:2: error: implicit declaration of function 'schedule_timeout'
drivers/rtc/rtc-imxdi.c: In function 'dryice_norm_irq':
drivers/rtc/rtc-imxdi.c:329:34: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
This is a regression from
4ba8216 (BKL: That's all, folks)
that removes #inclusion of <linux/sched.h> from include/linux/hardirq.h.
Adding
#include <linux/sched.h>
to the driver fixes it, but I wonder if that is the correct fix because
the driver only uses wait_event_interruptible_timeout (and
wake_up_interruptible) explicitly but none of the three undeclared
symbols.
Any insight welcome.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next reply other threads:[~2011-09-06 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 18:29 Uwe Kleine-König [this message]
2011-09-08 15:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906182928.GJ28816@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®