From: Greg KH <greg@kroah.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Oren Weil <oren.jer.weil@intel.com>,
devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org,
gregkh@suse.de, linux-kernel@vger.kernel.org,
tomas.winkler@intel.com, alan@linux.intel.com
Subject: Re: [PATCH 05/12] staging: mei: adding watchdog ping
Date: Tue, 6 Sep 2011 16:48:11 -0700 [thread overview]
Message-ID: <20110906234811.GA15235@kroah.com> (raw)
In-Reply-To: <20110831165224.GF3705@shale.localdomain>
On Wed, Aug 31, 2011 at 07:52:24PM +0300, Dan Carpenter wrote:
> On Wed, Aug 31, 2011 at 04:42:41PM +0300, Oren Weil wrote:
> > +static int mei_wd_ops_ping(struct watchdog_device *wd_dev)
> > +{
> > + int ret = 0;
> > + struct mei_device *dev;
> > + dev = pci_get_drvdata(mei_device);
> > +
> > + if (!dev)
> > + return -ENODEV;
> > +
> > + mutex_lock(&dev->device_lock);
> > +
> > + if (dev->wd_cl.state != MEI_FILE_CONNECTED) {
> > + dev_dbg(&dev->pdev->dev, "wd is not connected.\n");
> > + ret = -ENODEV;
> > + goto end;
> > + }
> > +
> > + /* Check if we can send the ping to HW*/
> > + if (dev->mei_host_buffer_is_empty &&
> > + mei_flow_ctrl_creds(dev, &dev->wd_cl) > 0) {
> > + dev->mei_host_buffer_is_empty = false;
> ^^^^^^^^^^^^^^^^
>
> This is a two tab indent. Don't do that.
Yeah, that's odd.
Oren, care to redo this patch and resend the whole series?
thanks,
greg k-h
next prev parent reply other threads:[~2011-09-06 23:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 13:42 [PATCH 00/12] staging: mei: adding new watchdog core support Oren Weil
2011-08-31 13:42 ` [PATCH 01/12] staging: mei: removing dependency between WD and AMTHI init function Oren Weil
2011-08-31 13:42 ` [PATCH 02/12] staging: mei: fix register access function comments Oren Weil
2011-08-31 13:42 ` [PATCH 03/12] staging: mei: registering the MEI driver with the kernel watchdog core interface Oren Weil
2011-08-31 13:42 ` [PATCH 04/12] staging: mei: adding watchdog ops Oren Weil
2011-08-31 13:42 ` [PATCH 05/12] staging: mei: adding watchdog ping Oren Weil
2011-08-31 16:52 ` Dan Carpenter
2011-09-06 23:48 ` Greg KH [this message]
2011-08-31 13:42 ` [PATCH 06/12] staging: mei: adding set_timeout watchdog function Oren Weil
2011-08-31 13:42 ` [PATCH 07/12] staging: mei: renaming delayed work field and function to a meaningful name Oren Weil
2011-08-31 13:42 ` [PATCH 08/12] staging: mei: resuming timer regardless of the watchdog timeout value Oren Weil
2011-08-31 13:42 ` [PATCH 09/12] stagign: mei: client init code cleanup Oren Weil
2011-08-31 13:42 ` [PATCH 10/12] staging: mei: removing wd module parameters Oren Weil
2011-08-31 13:42 ` [PATCH 11/12] staging: mei: adding mei_wd_stop function comment Oren Weil
2011-08-31 13:42 ` [PATCH 12/12] staging: mei: adding watchdog core dependency to kconfig Oren Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906234811.GA15235@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®