mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	devel@driverdev.osuosl.org, hverkuil@xs4all.nl, gregkh@suse.de,
	mchehab@redhat.com
Subject: Re: [PATCH] Staging: dt3155v4l: Convert printk's to pr_<level>
Date: Tue, 6 Sep 2011 16:52:53 -0700	[thread overview]
Message-ID: <20110906235253.GC26281@kroah.com> (raw)
In-Reply-To: <201109011653.56089.hartleys@visionengravers.com>

On Thu, Sep 01, 2011 at 04:53:55PM -0700, H Hartley Sweeten wrote:
> Convert all the printk(KERN_<level>) messages in the driver to pr_<level>()
> and use pr_fmt to provide the module name.

What's wrong with using dev_* instead of pr_*?  Lots of these should be
converted to that format instead, right?

thanks,

greg k-h

  reply	other threads:[~2011-09-06 23:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 23:53 H Hartley Sweeten
2011-09-06 23:52 ` Greg KH [this message]
2011-09-07  0:15   ` H Hartley Sweeten
2011-09-07 15:10     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110906235253.GC26281@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=hartleys@visionengravers.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome