From: Greg KH <greg@kroah.com>
To: Arvydas Sidorenko <asido4@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] one typo fix
Date: Tue, 6 Sep 2011 16:57:55 -0700 [thread overview]
Message-ID: <20110906235755.GA10586@kroah.com> (raw)
In-Reply-To: <1315166085-27984-1-git-send-email-asido4@gmail.com>
On Sun, Sep 04, 2011 at 09:54:43PM +0200, Arvydas Sidorenko wrote:
> Signed-off-by: Arvydas Sidorenko <asido4@gmail.com>
> ---
> drivers/staging/crystalhd/bc_dts_defs.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/bc_dts_defs.h b/drivers/staging/crystalhd/bc_dts_defs.h
> index 778e76a..8c6ac3e 100644
> --- a/drivers/staging/crystalhd/bc_dts_defs.h
> +++ b/drivers/staging/crystalhd/bc_dts_defs.h
> @@ -84,7 +84,7 @@ enum BC_SW_OPTIONS {
> BC_OPT_LINK_OUT_ENCRYPT = BC_BIT(29),
> };
>
> -struct BC_REG_CONFIG{
> +struct BC_REG_CONFIG {
That's not a "typo", it's a style fix, right?
Also, please give a good Subject: line for your emails. This one would
be:
Subject: staging: crystalhd: bc_dts_defs.h: fix a coding style issue
Care to redo all 3 patches in this series in this way, properly
describing what you are doing, so I can apply them?
thanks,
greg k-h
prev parent reply other threads:[~2011-09-07 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 19:54 Arvydas Sidorenko
2011-09-04 19:54 ` [PATCH 2/3] syntax typos fix Arvydas Sidorenko
2011-09-04 19:54 ` [PATCH 3/3] typedef cleanup Arvydas Sidorenko
2011-09-08 17:35 ` Chris Boot
2011-09-09 7:30 ` Dan Carpenter
2011-09-09 8:21 ` Chris Boot
2011-09-06 23:57 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906235755.GA10586@kroah.com \
--to=greg@kroah.com \
--cc=asido4@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome