From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756634Ab1IHX6i (ORCPT ); Thu, 8 Sep 2011 19:58:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45953 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755876Ab1IHX6f (ORCPT ); Thu, 8 Sep 2011 19:58:35 -0400 Date: Thu, 8 Sep 2011 12:12:37 -0700 From: Greg KH To: Olaf Hering Cc: "K. Y. Srinivasan" , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, virtualization@lists.osdl.org Subject: Re: [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name Message-ID: <20110908191237.GB8552@suse.de> References: <20110908162650.GA10699@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110908162650.GA10699@aepfle.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2011 at 06:26:50PM +0200, Olaf Hering wrote: > > mkinitrd relies on /sys/class/scsi_host/*/proc_name instead of > /sys/block/sd*/device/../../../moalias to get the scsi driver module > name. > As a fallback the sysfs driver name could be used, which does not match > the module name either ('storvsc' vs. 'hv_storvsc'). > > Signed-off-by: Olaf Hering > > --- > drivers/staging/hv/storvsc_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/drivers/staging/hv/storvsc_drv.c > +++ b/drivers/staging/hv/storvsc_drv.c > @@ -1333,7 +1333,8 @@ static DEF_SCSI_QCMD(storvsc_queuecomman > /* Scsi driver */ > static struct scsi_host_template scsi_driver = { > .module = THIS_MODULE, > - .name = "storvsc_host_t", > + .name = "hv_storvsc", > + .proc_name = "hv_storvsc", Shouldn't this be MODULE_NAME so it handles any potential name change in the future and makes it a bit more obvious as to what is going on here? thanks, greg k-h