From: Tejun Heo <tj@kernel.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, yinghai@kernel.org, bp@alien8.de
Subject: Re: [PATCH] arch/x86/mm/init_32.c: quiet sparse noise; local functions should be static
Date: Sun, 11 Sep 2011 10:07:39 +0900 [thread overview]
Message-ID: <20110911010739.GH29319@htj.dyndns.org> (raw)
In-Reply-To: <201109091609.23433.hartleys@visionengravers.com>
On Fri, Sep 09, 2011 at 04:09:23PM -0700, H Hartley Sweeten wrote:
> Local functions should be marked static. This quiets the following
> sparse noise:
>
> warning: symbol 'lowmem_pfn_init' was not declared. Should it be static?
> warning: symbol 'highmem_pfn_init' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers,com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Borislav Petkov <bp@alien8.de>
Looks good to me.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2011-09-11 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 23:09 H Hartley Sweeten
2011-09-11 1:07 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110911010739.GH29319@htj.dyndns.org \
--to=tj@kernel.org \
--cc=bp@alien8.de \
--cc=hartleys@visionengravers.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®