From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757934Ab1ILPNN (ORCPT ); Mon, 12 Sep 2011 11:13:13 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:58675 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757475Ab1ILPNM (ORCPT ); Mon, 12 Sep 2011 11:13:12 -0400 Date: Mon, 12 Sep 2011 11:13:10 -0400 From: Christoph Hellwig To: Vivek Goyal Cc: Christoph Hellwig , Jens Axboe , linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/2] block: refactor generic_make_request Message-ID: <20110912151310.GA7188@infradead.org> References: <20110911145053.GA28996@infradead.org> <20110912134202.GA22953@infradead.org> <20110912150935.GA27453@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110912150935.GA27453@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2011 at 11:09:35AM -0400, Vivek Goyal wrote: > On Mon, Sep 12, 2011 at 09:42:02AM -0400, Christoph Hellwig wrote: > > [..] > > + > > /* following loop may be a bit non-obvious, and so deserves some > > * explanation. > > * Before entering the loop, bio->bi_next is NULL (as all callers > > @@ -1557,16 +1561,15 @@ void generic_make_request(struct bio *bi > > * from the top. In this case we really did just take the bio > > * of the top of the list (no pretending) and so remove it from > > * bio_list, and call into __generic_make_request again. > ^^^^^^^^^^ > You got rid of __generic_make_request(). Now above comment has stale > reference to it. Yeah, this should be ->make_request now.