mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
	linux-kernel@vger.kernel.org, dvlasenk@redhat.com
Subject: Re: [PATCH v2] Make PTRACE_SEIZE set ptrace options specified in 'data' parameter
Date: Tue, 13 Sep 2011 17:00:04 +0900	[thread overview]
Message-ID: <20110913080004.GF11397@mtj.dyndns.org> (raw)
In-Reply-To: <20110911181442.GA22239@redhat.com>

On Sun, Sep 11, 2011 at 08:14:42PM +0200, Oleg Nesterov wrote:
> We need to rework the locking, yes. But we need the lock which protects
> the parent's list_head (currently we rely on tasklist). Yes, a single
> lock can't help. We already use ->cred_guard_mutex though.
> 
> This needs more thinking, but imho child->siglock is pointless here.

But we can at least guarantee that if ->ptrace is set (or clear) while
tracee's siglock is held, its ->parent points to the tracer (or not).
At any rate, AFAICS, this currently doesn't really matter.  I
suggested it mainly because it would make the locking change easier.

Thanks.

-- 
tejun

      reply	other threads:[~2011-09-13  8:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 21:40 Denys Vlasenko
2011-09-07 23:55 ` Pedro Alves
2011-09-08  0:44 ` Tejun Heo
2011-09-08 18:17   ` Oleg Nesterov
2011-09-11  2:05     ` Tejun Heo
2011-09-11 18:14       ` Oleg Nesterov
2011-09-13  8:00         ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913080004.GF11397@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=dvlasenk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®