From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089Ab1IPKjs (ORCPT ); Fri, 16 Sep 2011 06:39:48 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54280 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759Ab1IPKjr (ORCPT ); Fri, 16 Sep 2011 06:39:47 -0400 X-Originating-IP: 217.70.178.129 X-Originating-IP: 147.83.37.68 From: "Leopold Palomo-Avellaneda" To: Bastien ROUCARIES Subject: Re: [PATCH/RFC] parport_pc: remove ancient, overeager quirk that disables EPP support on many chipsets Date: Fri, 16 Sep 2011 12:39:40 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.32-5-amd64; KDE/4.4.5; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, Adam Baker , linux-parport@lists.infradead.org, 630593@bugs.debian.org, Nicos Gollan , Greg KH , Alan Cox , Alexander Gordeev , Jonathan Nieder References: <201109151441.15015.leo@alaxarxa.net> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201109161239.40592.leo@alaxarxa.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A Dijous, 15 de setembre de 2011, Bastien ROUCARIES va escriure: > On Thu, Sep 15, 2011 at 3:41 PM, Bastien ROUCARIES > wrote: > > On Thu, Sep 15, 2011 at 2:41 PM, Leopold Palomo-Avellaneda > > wrote: > >> Hi again, > >> > >> sorry for the noise and my mistake. The patch... > >> > >> there's a bug in the parport module that have been reported (in another > >> places) some time ago [1]. Also, this bug was reported at Redhat [2], but > >> nobody follow the report and it was closed. > > Moreover they are more detail about this bug here you should contact > davbid campell > > http://lists.infradead.org/pipermail/linux-parport/2004-March/000048.html I think that this is a good approach, but it seems that this patch go to nowhere.... also solves another question of timeouts. Leo > Bastien > > >> As Adam Baker said [1] : > >> > >> > >> A long time ago (~ 10 years), Intel produced a chipset that > > > > Why not check dmi years for this test and do the test only for board > > before 2000 ? Better safe than sorry > > > > Bastien > > > > > > > >> included broken EPP support. The Linux parport driver was written to detect > >> such a chipset and disable EPP support on it. Unfortunately the test that was > >> written gives false positives for many current chipsets and no-one seems to > >> know exactly what the problem hardware was, let alone have a sample of it to > >> see if a better test can be written. After such a long time it is probably > >> appropriate to just remove the test (on average it does more harm than good) > >> however you are correct in asserting the driver is unmaintained so no-one is > >> bothering to fix it. > >> > >> > >> I have applied the patch to the standard debian kernel and vanilla kernels and > >> runs perfectly. The patch simply erases a check. Applied to some Dell > >> hardware, now the EPP mode is detected and, after some initial tests it's > >> working. > >> > >> Please, apply the patch. > >> > >> Best regards, > >> > >> Leo > >> > >> [1] http://lists.infradead.org/pipermail/linux-parport/2008- March/000628.html > >> [2] https://bugzilla.redhat.com/show_bug.cgi?id=284471 > >> > >> > >> Signed-off-by: Adam Baker > >> Signed-off-by: Leopold Palomo-Avellaneda > >> > >> > >> --- > >> > > > -- -- Linux User 152692 Catalonia