From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492Ab1IQNxt (ORCPT ); Sat, 17 Sep 2011 09:53:49 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:42379 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab1IQNxs (ORCPT ); Sat, 17 Sep 2011 09:53:48 -0400 Date: Sat, 17 Sep 2011 09:53:47 -0400 From: Christoph Hellwig To: Marco Stornelli Cc: Linux FS Devel , Linux Kernel Subject: Re: [PATCH] xip: export xip_file_fault Message-ID: <20110917135346.GA31551@infradead.org> References: <4E749003.30909@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E749003.30909@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 17, 2011 at 02:18:11PM +0200, Marco Stornelli wrote: > From: Marco Stornelli > > There aren't sufficient sync points for a fs for xip operations. In > particular for the mmap case. It can be not sufficient to lock/unlock > to do some operation inside get_xip_mem callback. For xip_file_read > it's really easy to write a fs specific wrapper, xip_file_write hold > i_mutex so no problem. With this patch it's possible to reuse the > generic xip_file_fault, using a wrapper function in a fs, without to > reinvent the wheel. As usual please send patches to add exports only while adding callers for it.