From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: linux-omap@vger.kernel.org, "Ohad Ben-Cohen" <ohad@wizery.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/omap: Fix build error with !IOMMU_SUPPORT
Date: Sun, 18 Sep 2011 02:02:22 +0200 [thread overview]
Message-ID: <201109180202.23123.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1316009259-18052-1-git-send-email-joerg.roedel@amd.com>
Hi Joerg,
On Wednesday 14 September 2011 16:07:39 Joerg Roedel wrote:
> Without this patch it is possible to select the VIDEO_OMAP3
> driver which then selects OMAP_IOVMM. But the omap iommu
> driver is not compiled without IOMMU_SUPPORT enabled. Fix
> that by forcing OMAP_IOMMU and OMAP_IOVMM are enabled before
> VIDEO_OMAP3 can be selected.
What about making VIDEO_OMAP3 select IOMMU_SUPPORT instead then ? Your patch
would make the OMAP3 ISP driver disappear from the menu until IOMMU_SUPPORT
gets turned on, which can confuse users.
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> drivers/iommu/Kconfig | 4 ++--
> drivers/media/video/Kconfig | 3 +--
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index d901930..ae46776 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -114,8 +114,8 @@ config OMAP_IOMMU
> select IOMMU_API
>
> config OMAP_IOVMM
> - tristate
> - select OMAP_IOMMU
> + tristate "OMAP IO Virtual Memory Manager Support"
> + depends on OMAP_IOMMU
>
> config OMAP_IOMMU_DEBUG
> tristate "Export OMAP IOMMU/IOVMM internals in DebugFS"
> diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
> index 6a25fad..6201069 100644
> --- a/drivers/media/video/Kconfig
> +++ b/drivers/media/video/Kconfig
> @@ -763,8 +763,7 @@ source "drivers/media/video/m5mols/Kconfig"
>
> config VIDEO_OMAP3
> tristate "OMAP 3 Camera support (EXPERIMENTAL)"
> - select OMAP_IOVMM
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && ARCH_OMAP3 &&
> EXPERIMENTAL
> + depends on OMAP_IOVMM && VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API &&
> ARCH_OMAP3 && EXPERIMENTAL
> ---help---
> Driver for an OMAP 3 camera controller.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2011-09-18 0:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 14:07 Joerg Roedel
2011-09-14 18:57 ` Ohad Ben-Cohen
2011-09-15 10:45 ` Roedel, Joerg
2011-09-16 9:57 ` Ohad Ben-Cohen
2011-09-18 0:02 ` Laurent Pinchart [this message]
2011-09-20 10:01 ` Roedel, Joerg
2011-09-20 10:54 ` Laurent Pinchart
2011-09-22 13:48 ` Felipe Contreras
2011-09-23 9:05 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109180202.23123.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®