From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651Ab1IRTXh (ORCPT ); Sun, 18 Sep 2011 15:23:37 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:58740 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756611Ab1IRTXg (ORCPT ); Sun, 18 Sep 2011 15:23:36 -0400 Date: Sun, 18 Sep 2011 21:23:33 +0200 From: Markus Trippelsdorf To: Linus Torvalds Cc: David Miller , akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [GIT] Networking Message-ID: <20110918192333.GA1641@x4.trippels.de> References: <20110918.022125.1554085675403900813.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011.09.18 at 11:06 -0700, Linus Torvalds wrote: > 2011/9/17 David Miller : > > > > dpward (2): > >      net: Make flow cache namespace-aware > >      net: Handle different key sizes between address families in flow cache > > > > nhorman (1): > >      net: don't clear IFF_XMIT_DST_RELEASE in ether_setup > > > > rajan.aggarwal85@gmail.com (1): > >      net/can/af_can.c: Change del_timer to del_timer_sync > > Guys, if somebody has such a broken email setup that they don't even > show their own name, don't take patches from them. > > If you cannot even set up email sanely, there is zero reason to > believe that the patch should be good. And if the patch is trivial and > you want to take it despite the source of the patch being crap, please > spend the five seconds to fix it up. > > Proper names are part of the commit message. Don't make it look like > crap. I get ugly flashbacks to SVN or CVS when I see stuff like this. > Don't do it. Plus commit 946cedccbd73874 breaks the build: LD init/built-in.o LD .tmp_vmlinux1 net/built-in.o:sysctl_net.c:function tcp_v4_conn_request: error: undefined reference to 'cookie_v4_init_sequence' make: *** [.tmp_vmlinux1] Error 1 commit 946cedccbd7387488d2cee5da92cdfeb28d2e670 Author: Eric Dumazet Date: Tue Aug 30 03:21:44 2011 +0000 tcp: Change possible SYN flooding messages "Possible SYN flooding on port xxxx " messages can fill logs on servers. Change logic to log the message only once per listener, and add two new SNMP counters to track : TCPReqQFullDoCookies : number of times a SYNCOOKIE was replied to client TCPReqQFullDrop : number of times a SYN request was dropped because syncookies were not enabled. Based on a prior patch from Tom Herbert, and suggestions from David. -- Markus