From: David Miller <davem@davemloft.net>
To: robherring2@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
marc.zyngier@arm.com, thomas.abraham@linaro.org,
jamie@jamieiles.com, b-cousson@ti.com, shawn.guo@linaro.org,
dave.martin@linaro.org, linux@arm.linux.org.uk,
rob.herring@calxeda.com
Subject: Re: [PATCH 0/3] GIC OF bindings
Date: Tue, 20 Sep 2011 22:49:10 -0400 (EDT) [thread overview]
Message-ID: <20110920.224910.1996429830782124690.davem@davemloft.net> (raw)
In-Reply-To: <1316550244-3655-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <robherring2@gmail.com>
Date: Tue, 20 Sep 2011 15:24:01 -0500
> Hopefully, this is the final or near final version of GIC binding support.
>
> Changes from the previous version:
> - SPIs and PPIs are numbered starting at 0. Now the gic has it's own irq
> domain translate function instead of the simple domain one.
> - interrupt cell format has changed based on Grant's proposal.
> - Dropped "ARM: gic: allow irq_start to be 0". Instead, the first 16 irqs
> are skipped and the domain irq_base adjusted accordingly.
> - Added a fix to of_irq_find_parent when the parent == child.
> - Renamed intc_desc.parent to intc_desc.interrupt_parent.
> - Implemented Grant's algorithm for walking the list of interrupt
> controllers. Added a return value to interrupt init functions, so they
> don't get added to the parent list on a init failure.
>
> The changes are significant enough that I did not include previous
> acked/reviewed/tested-by's.
Just out of curiosity where does this "interrupt-parent" property
come from?
On platforms I am familiar with, the parent path is walked to the root
and we stop at device nodes that have "interrupt-map" and
"interrupt-map-mask" properties.
The map and mask are applied to the "reg" property of the device in
question to see which map entry matches, if a match is found the map
entry contains the translated interrupt.
And this process continues over and over all the way to the root to get
the system interrupt that processor actually deals with.
The mechanism shown here seems overly simplistic and not able to handle
the cases handled by existing OF property schemes in use for several
years on real systems.
next prev parent reply other threads:[~2011-09-21 2:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:24 Rob Herring
2011-09-20 20:24 ` [PATCH 1/3] of/irq: of_irq_find_parent: check for parent equal to child Rob Herring
2011-09-20 21:01 ` Grant Likely
2011-09-20 20:24 ` [PATCH 2/3] of/irq: introduce of_irq_init Rob Herring
2011-09-20 23:00 ` Grant Likely
2011-09-21 10:01 ` Jamie Iles
2011-09-23 2:21 ` [PATCH v3] " Rob Herring
2011-09-23 5:14 ` Grant Likely
2011-09-26 19:24 ` [PATCH v4] " Rob Herring
2011-09-27 1:53 ` Grant Likely
2011-09-27 13:03 ` Rob Herring
2011-09-27 21:24 ` Grant Likely
2011-09-20 20:24 ` [PATCH 3/3] ARM: gic: add OF based initialization Rob Herring
2011-09-20 23:08 ` Grant Likely
2011-09-21 1:54 ` Rob Herring
2011-09-21 17:15 ` Cousson, Benoit
2011-09-21 17:55 ` Rob Herring
2011-09-21 19:28 ` Cousson, Benoit
2011-09-21 20:27 ` Cousson, Benoit
2011-09-26 19:57 ` Jamie Iles
2011-09-26 20:49 ` Rob Herring
2011-09-26 21:11 ` Jamie Iles
2011-09-26 21:32 ` Rob Herring
2011-09-26 22:00 ` Jamie Iles
2011-09-26 22:29 ` Jamie Iles
2011-09-21 2:49 ` David Miller [this message]
2011-09-21 4:14 ` [PATCH 0/3] GIC OF bindings Grant Likely
2011-09-21 4:58 ` Mitch Bradley
2011-09-21 5:21 ` David Miller
2011-09-21 7:11 ` Mitch Bradley
2011-09-21 5:16 ` Segher Boessenkool
2011-09-21 9:43 ` Shawn Guo
2011-09-30 19:27 Rob Herring
2011-10-04 16:15 ` Rob Herring
2011-10-08 14:04 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920.224910.1996429830782124690.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b-cousson@ti.com \
--cc=dave.martin@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®