From: Borislav Petkov <bp@alien8.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: 李朝明 <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org,
'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: 答复: 答复: 3.1-rc6+ rtl8192se issue
Date: Thu, 22 Sep 2011 09:51:15 +0200 [thread overview]
Message-ID: <20110922075115.GA17640@liondog.tnic> (raw)
In-Reply-To: <4E7AAB8B.40900@lwfinger.net>
On Wed, Sep 21, 2011 at 10:29:15PM -0500, Larry Finger wrote:
> On 09/21/2011 08:24 PM, 李朝明 wrote:
> > Dear Sir:
> >
> > I can't find _rtl_pci_lps_leave_tasklet in my driver, So I want to
> > kown which driver did you use.
> > Would you like to try this new driver with ips =0 and lps = 0, or
> > some combination of these two functions.
>
> It is not in my driver either. Where did that driver come from?
That's actually _rtl_pci_ips_leave_tasklet with an "i"
in "_ips_" and it is a wrapper around rtl_lps_leave() in
<drivers/net/wireless/rtlwifi/pci.c>
Basically, that's the tasklet handler for ips_leave_tasklet regged in
_rtl_pci_init_struct():
tasklet_init(&rtlpriv->works.ips_leave_tasklet,
(void (*)(unsigned long))_rtl_pci_ips_leave_tasklet,
(unsigned long)hw);
The sluggishness is consistent with the tasklet choking on something,
from looking at rtl_lps_leave() it grabs some spinlocks and then enables
IRQs in the middle of it with a very explanatory comment /* FIXME */
ontop of it which looks very suspicious to me:
/*Leave the leisure power save mode.*/
void rtl_lps_leave(struct ieee80211_hw *hw)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw));
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
spin_lock(&rtlpriv->locks.lps_lock);
if (ppsc->fwctrl_lps) {
if (ppsc->dot11_psmode != EACTIVE) {
/*FIX ME */
rtlpriv->cfg->ops->enable_interrupt(hw);
...
But since I don't know anything about networking drivers, I'm actually
hoping that you guys could have an idea here.
HTH.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2011-09-22 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110915124406.GA14374@gere.osrc.amd.com>
2011-09-15 15:23 ` Larry Finger
2011-09-15 18:41 ` Borislav Petkov
2011-09-16 18:03 ` Borislav Petkov
[not found] ` <CD4D8CF16C39438E82FE8241C9AF80F4@realsil.com.cn>
2011-09-19 9:54 ` 答复: " Borislav Petkov
2011-09-19 17:13 ` Borislav Petkov
[not found] ` <20110921185816.GA2036@gere.osrc.amd.com>
[not found] ` <791179BCE62F4954AB936E6CAC9CA977@realsil.com.cn>
[not found] ` <4E7AAB8B.40900@lwfinger.net>
2011-09-22 7:51 ` Borislav Petkov [this message]
[not found] ` <6452E68488784D0EA32E4BDF1B941EFB@realsil.com.cn>
2011-09-23 10:33 ` 答复: 答复: " Borislav Petkov
2011-09-23 13:50 ` Larry Finger
2011-09-23 16:34 ` Larry Finger
2011-09-28 13:18 ` Borislav Petkov
2011-09-29 1:57 ` Larry Finger
2011-10-05 15:15 ` Borislav Petkov
2011-10-06 2:37 ` Larry Finger
2011-11-15 13:59 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922075115.GA17640@liondog.tnic \
--to=bp@alien8.de \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®