Re: [PATCH] Initialize pointer on request_firmware

[Borislav Petkov <bp@alien8.de>]

On Wed, Sep 21, 2011 at 11:55:15PM -0300, Lucas C. Villa Real wrote:
> Hello, folks,
> 
> I've seen some kernel oopses when suspending my machine. The problem comes from isight_firmware, which assumes that, on error, a call to request_firmware() will initialize the provided pointer to the firmware image to NULL.
> 
> The patch below fixes the isight_firmware side of the problem and also ensures that request_firmware() always sets the pointer to NULL on such cases (it currently does that for all except one situation).
> 
> Signed-off-by: Lucas C. Villa Real <lucasvr@gobolinux.org>
> 
> --- linux-3.0.4/drivers/base/firmware_class.c.orig	2011-09-21 21:03:01.000000000 -0300
> +++ linux-3.0.4/drivers/base/firmware_class.c	2011-09-21 21:03:13.000000000 -0300
> @@ -523,6 +523,7 @@ static int _request_firmware(const struc
>  
>  	if (WARN_ON(usermodehelper_is_disabled())) {
>  		dev_err(device, "firmware: %s will not be loaded\n", name);
> +		*firmware_p = NULL;
>  		return -EBUSY;
>  	}

Looks like f45f3c1f3f616 needs backporting to stable, if it hasn't
happened yet. Oh, and then there's caca9510ff4e5 too which adds this
exit path to the goto out label as the rest of the function.

Adding some more people to Cc.

>  
> --- linux-3.0.4/drivers/usb/misc/isight_firmware.c.orig	2011-09-21 20:47:39.000000000 -0300
> +++ linux-3.0.4/drivers/usb/misc/isight_firmware.c	2011-09-21 20:47:46.000000000 -0300
> @@ -39,7 +39,7 @@ static int isight_firmware_load(struct u
>  {
>  	struct usb_device *dev = interface_to_usbdev(intf);
>  	int llen, len, req, ret = 0;
> -	const struct firmware *firmware;
> +	const struct firmware *firmware = NULL;
>  	unsigned char *buf = kmalloc(50, GFP_KERNEL);
>  	unsigned char data[4];
>  	const u8 *ptr;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Regards/Gruss,
    Boris.