From: Jiri Olsa <jolsa@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH] perf tools: Fix tracing info recording
Date: Sun, 25 Sep 2011 15:34:06 +0200 [thread overview]
Message-ID: <20110925133406.GB2702@jolsa.brq.redhat.com> (raw)
In-Reply-To: <20110921153016.GB1811@somewhere>
On Wed, Sep 21, 2011 at 05:30:24PM +0200, Frederic Weisbecker wrote:
> On Wed, Sep 14, 2011 at 03:58:40PM +0200, Jiri Olsa wrote:
> > The tracing information is part of the perf data file. It contains
> > several files from within the tracing debugfs and procs directories.
> >
> > Beside some static header files, for each tracing event the format
> > file is added. The /proc/kallsyms file is also added.
> >
> > The tracing data are stored with preceeding size. This is causing some
> > dificulties for pipe output, since there's no way to tell debugfs/proc
> > file size before reading it. So, for pipe output, all the debugfs files
> > were read twice. Once to get the overall size and once to store the
> > content itself. This can cause problem in case any of these file
> > changed, within the storage time.
> >
> > Fixing this behaviour by using temp file in case of pipe output. The
> > debugfs/proc files are being read only once, ensuring the integrity of
> > the tracing data.
> >
> > Also changing the way the event files are searched by quering specified
> > event files directly, instead of walking the events directory.
> >
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
>
> Looks good overall, but I have some comments about details:
hi,
thanks for comments,
I'll make the changes and send out new version soon
jirka
next prev parent reply other threads:[~2011-09-25 13:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 14:23 [PATCH] perf, tool, record: Fix the header generation for pipe Jiri Olsa
2011-08-22 14:38 ` Eric Dumazet
2011-08-22 14:52 ` Jiri Olsa
2011-08-22 15:51 ` Eric Dumazet
2011-08-22 16:07 ` Jiri Olsa
2011-08-29 13:20 ` Arnaldo Carvalho de Melo
2011-08-29 13:41 ` Jiri Olsa
2011-08-29 14:25 ` Arnaldo Carvalho de Melo
2011-09-14 13:58 ` [PATCH] perf tools: Fix tracing info recording Jiri Olsa
2011-09-14 15:44 ` Neil Horman
2011-09-21 15:30 ` Frederic Weisbecker
2011-09-25 13:34 ` Jiri Olsa [this message]
2011-09-26 9:11 ` [PATCHv2 1/2] " Jiri Olsa
2011-09-26 9:11 ` [PATCHv2 1/2] perf tools: Collect tracing event data files directly Jiri Olsa
2011-09-26 13:36 ` Steven Rostedt
2011-09-26 14:56 ` Jiri Olsa
2011-09-28 13:55 ` Frederic Weisbecker
2011-09-28 14:03 ` Steven Rostedt
2011-09-28 14:17 ` Frederic Weisbecker
2011-09-28 14:23 ` Steven Rostedt
2011-09-28 16:56 ` Ingo Molnar
2011-09-28 17:10 ` Steven Rostedt
2011-10-10 5:22 ` Ingo Molnar
2011-10-10 12:27 ` Steven Rostedt
2011-10-10 14:21 ` Frederic Weisbecker
2011-09-26 13:43 ` David Ahern
2011-09-26 14:58 ` Jiri Olsa
2011-09-26 9:11 ` [PATCHv2 2/2] perf tools: Fix tracing info recording Jiri Olsa
2011-09-29 15:05 ` [PATCHv3 0/2] " Jiri Olsa
2011-09-29 15:05 ` [PATCHv3 1/2] perf tools: Fix raw sample reading Jiri Olsa
2011-09-29 15:34 ` David Ahern
2011-09-29 15:05 ` [PATCHv3 2/2] perf tools: Fix tracing info recording Jiri Olsa
2011-10-13 14:00 ` Jiri Olsa
2011-10-20 13:59 ` [PATCHv4] " Jiri Olsa
2011-10-20 21:28 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110925133406.GB2702@jolsa.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®