From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Turner <pjt@google.com>, Venki Pallipadi <venki@google.com>,
Ingo Molnar <mingo@elte.hu>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] sched: fix nohz idle load balancer issues
Date: Mon, 26 Sep 2011 17:31:05 +0530 [thread overview]
Message-ID: <20110926120105.GA8593@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110926115049.GA22604@linux.vnet.ibm.com>
* Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> [2011-09-26 17:20:49]:
> @@ -4695,8 +4719,11 @@ static inline int nohz_kick_needed(struc
> second_pick_cpu = atomic_read(&nohz.second_pick_cpu);
>
> if (first_pick_cpu < nr_cpu_ids && first_pick_cpu != cpu &&
> - second_pick_cpu < nr_cpu_ids && second_pick_cpu != cpu)
> + second_pick_cpu < nr_cpu_ids && second_pick_cpu != cpu) {
> + if (rq->nr_running > 1)
> + return 1;
> return 0;
> + }
I should have added a comment to explain this change ..will do it in
next version (along with any other changes suggested).
- vatsa
next prev parent reply other threads:[~2011-09-26 12:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 11:50 Srivatsa Vaddagiri
2011-09-26 12:01 ` Srivatsa Vaddagiri [this message]
2011-09-27 6:32 ` Ingo Molnar
2011-09-27 10:31 ` Srivatsa Vaddagiri
2011-09-27 13:39 ` Ingo Molnar
2011-09-27 19:53 ` Venki Pallipadi
2011-09-27 23:49 ` Suresh Siddha
2011-09-28 4:15 ` Srivatsa Vaddagiri
2011-09-29 0:47 ` Suresh Siddha
2011-09-29 2:13 ` Srivatsa Vaddagiri
2011-09-29 8:15 ` Peter Zijlstra
2011-09-29 17:13 ` Suresh Siddha
2011-09-28 4:34 ` Srivatsa Vaddagiri
2011-09-28 4:39 ` Srivatsa Vaddagiri
2011-09-28 5:06 ` Srivatsa Vaddagiri
2011-09-28 14:17 ` Srivatsa Vaddagiri
2011-09-28 14:27 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926120105.GA8593@linux.vnet.ibm.com \
--to=vatsa@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjt@google.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome