From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101Ab1I2JVU (ORCPT ); Thu, 29 Sep 2011 05:21:20 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:50206 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755048Ab1I2JVS (ORCPT ); Thu, 29 Sep 2011 05:21:18 -0400 Date: Thu, 29 Sep 2011 10:21:03 +0100 From: Will Deacon To: Stephen Boyd Cc: Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , David Brown Subject: Re: [PATCHv2 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice Message-ID: <20110929092102.GB25061@e102144-lin.cambridge.arm.com> References: <1316568208-4518-1-git-send-email-sboyd@codeaurora.org> <1316568208-4518-2-git-send-email-sboyd@codeaurora.org> <4E83D25C.6020306@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E83D25C.6020306@codeaurora.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2011 at 03:05:16AM +0100, Stephen Boyd wrote: > On 09/20/11 18:23, Stephen Boyd wrote: > > DEBUG_ICEDCC support is just another DEBUG_LL choice and > > selecting it along with other DEBUG_LL options doesn't make > > much sense. Put it into the DEBUG_LL choice to avoid confusion. > > > > Signed-off-by: Stephen Boyd > > Acked-by: Will Deacon > > --- > > > > Chatting with David Brown made me realize that this patch now forces > ICEDCC for anybody who selects DEBUG_LL and hasn't moved to adding a > Kconfig in the choice menu. I'm not sure if that actually matters since > it may be incentive to put your machine of choice into this menu. > > Otherwise, we may want to drop this until a later point, or just leave > it out of the choice menu altogether. Given that the ICEDCC stuff shouldn't cause any other problems by having it enabled (that is, your kernel should still boot) then we should be alright leaving this as-is while platforms move over to the new scheme. However, if we get attacked by the United Army of Enraged Platform Maintainers wanting to use earlyprintk, then I'm hiding behind you :) Will