mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	linux-kernel@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 02/11] virtio-pci: add PM notification handlers for restore, freeze, thaw, poweroff
Date: Fri, 30 Sep 2011 08:36:59 +0530	[thread overview]
Message-ID: <20110930030659.GA25524@amit-x200.redhat.com> (raw)
In-Reply-To: <1317321398.21918.7.camel@lappy>

On (Thu) 29 Sep 2011 [21:36:38], Sasha Levin wrote:
> 
> After drv->freeze() completes, the vq is freed from guest memory, but is
> there anything that prevents from the device to keep writing into that
> vq?
> 
> Shouldn't we set status to '0' before we free vqs?

Yes, this should be done in the driver code though, not in common
code.  I've fixed this in my tree.

Thanks,

		Amit

  reply	other threads:[~2011-09-30  3:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 15:25 [PATCH 00/11] virtio: Support for hibernation (S4) Amit Shah
2011-09-29 15:25 ` [PATCH 01/11] virtio: pci: switch to new PM API Amit Shah
2011-09-29 15:25 ` [PATCH 02/11] virtio-pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-09-29 18:36   ` Sasha Levin
2011-09-30  3:06     ` Amit Shah [this message]
2011-09-29 15:25 ` [PATCH 03/11] virtio: console: Move out vq and vq buf removal into separate functions Amit Shah
2011-09-29 15:26 ` [PATCH 04/11] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-09-29 15:26 ` [PATCH 05/11] virtio: blk: Move out vq initialization to separate function Amit Shah
2011-09-29 15:26 ` [PATCH 06/11] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-10-02  9:37   ` Michael S. Tsirkin
2011-10-03  9:16     ` Amit Shah
2011-10-03  9:24       ` Michael S. Tsirkin
2011-10-03  9:31         ` Amit Shah
2011-10-03  9:55           ` Michael S. Tsirkin
2011-09-29 15:26 ` [PATCH 07/11] virtio: net: Move out vq initialization into separate function Amit Shah
2011-09-29 15:26 ` [PATCH 08/11] virtio: net: Move out vq and vq buf removal " Amit Shah
2011-09-29 15:26 ` [PATCH 09/11] virtio: net: Add freeze, restore handlers to support S4 Amit Shah
2011-09-29 15:26 ` [PATCH 10/11] virtio: balloon: Move out vq initialization into separate function Amit Shah
2011-09-29 15:26 ` [PATCH 11/11] virtio: balloon: Add freeze, restore handlers to support S4 Amit Shah
2011-09-29 15:49 ` [PATCH 00/11] virtio: Support for hibernation (S4) Amit Shah
2011-09-29 16:48   ` Valdis.Kletnieks
2011-09-29 16:57     ` Amit Shah
     [not found] ` <cover.1317311033.git.amit.shah@redhat.com>
2011-09-29 15:49   ` [PATCH v2 04/11] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-09-29 15:49   ` [PATCH v2 05/11] virtio: blk: Move out vq initialization to separate function Amit Shah
2011-09-29 15:49   ` [PATCH v2 06/11] virtio: blk: Add freeze, restore handlers to support S4 Amit Shah
2011-09-29 15:49   ` [PATCH v2 09/11] virtio: net: " Amit Shah
2011-10-02  9:33     ` Michael S. Tsirkin
2011-11-15 12:29       ` Amit Shah
2011-11-15 12:51         ` Michael S. Tsirkin
2011-11-15 14:03           ` Amit Shah
2011-11-15 14:23             ` Michael S. Tsirkin
2011-11-15 14:31               ` Amit Shah
2011-11-15 14:36                 ` Michael S. Tsirkin
2011-11-15 15:37                   ` Amit Shah
2011-10-02  9:49 ` [PATCH 00/11] virtio: Support for hibernation (S4) Michael S. Tsirkin
2011-10-04  0:06   ` Rusty Russell
2011-11-15 12:52     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110930030659.GA25524@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome