From: Borislav Petkov <bp@alien8.de>
To: Simon Kirby <sim@hostway.ca>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [3.1-rc6] kmalloc(64) leak from IDE
Date: Fri, 30 Sep 2011 08:40:19 +0200 [thread overview]
Message-ID: <20110930064019.GA8092@liondog.tnic> (raw)
In-Reply-To: <20110929224505.GC7959@hostway.ca>
On Thu, Sep 29, 2011 at 03:45:05PM -0700, Simon Kirby wrote:
> Tested against on 2.6.39 with and without this patch, and it
> definitely leaks without it and does not leak with it. 3.0 and 3.1-rc8
> also seems good with the patch.
Good job, thanks!
> I tested on another IDE box (with an old Quantum Fireball 6.4GB!) and
:-)
> even with software RAID, I could not see the leak, so I had to use the
> original box, of course. The only difference I could see is the test
> box has piix and the production box has via82cxxx, but anyway...
It might be because the production box drive is reporting of being
capable of doing write cache flushes, i.e. it should say something like
ideXX: cache flushes supported
in dmesg. idedisk_prep_fn() is contingent on that and is used only then
AFAICT.
Thanks again for testing.
--
Regards/Gruss,
Boris.
prev parent reply other threads:[~2011-09-30 6:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 7:26 Simon Kirby
2011-09-22 8:48 ` Borislav Petkov
2011-09-22 20:23 ` Simon Kirby
2011-09-23 7:21 ` Borislav Petkov
2011-09-23 15:58 ` Bernd Schubert
2011-09-23 16:08 ` Bjorn Helgaas
2011-09-23 16:34 ` Bernd Schubert
2011-09-23 16:40 ` Bjorn Helgaas
2011-09-23 17:49 ` Bernd Schubert
2011-09-23 17:38 ` Simon Kirby
2011-09-25 8:58 ` Borislav Petkov
2011-09-26 8:05 ` Simon Kirby
2011-09-27 17:07 ` Borislav Petkov
2011-09-29 9:27 ` Borislav Petkov
2011-09-29 22:45 ` Simon Kirby
2011-09-30 6:40 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930064019.GA8092@liondog.tnic \
--to=bp@alien8.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sim@hostway.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®