From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756839Ab1I3QRE (ORCPT ); Fri, 30 Sep 2011 12:17:04 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:41590 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986Ab1I3QRC (ORCPT ); Fri, 30 Sep 2011 12:17:02 -0400 Date: Fri, 30 Sep 2011 18:17:32 +0200 From: Daniel Vetter To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 01/21] drm/i915: Enable digital port hotplug on PCH systems Message-ID: <20110930161732.GA2859@phenom.ffwll.local> Mail-Followup-To: Keith Packard , Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-2-git-send-email-keithp@keithp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1317344993-24945-2-git-send-email-keithp@keithp.com> X-Operating-System: Linux phenom 3.1.0-rc4+ User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2011 at 06:09:33PM -0700, Keith Packard wrote: > We were relying on the BIOS to set these bits, which doesn't always > happen. > > Signed-off-by: Keith Packard Ok, I'll try to increase our review-bandwidth for modesetting stuff by jumping into this maze myself. For the moment I'll shortly explain what I've actually checked so you know how much weight/little to attach to my r-b's. Checked with docs, noticed that the public one's lack register addresses for PCH regs ... Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48