mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: xiaojiang <jgq516@gmail.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-pm@lists.linux-foundation.org, Pavel Machek <pavel@ucw.cz>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	Kevin Hilman <khilman@ti.com>, Nishanth Menon <nm@ti.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Colin Cross <ccross@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mike Turquette <mturquette@ti.com>,
	myungjoo.ham@gmail.com
Subject: Re: [PATCH v13 2/4] PM: Introduce devfreq: generic DVFS framework with device-specific OPPs
Date: Fri, 30 Sep 2011 18:41:41 +0200	[thread overview]
Message-ID: <201109301841.41666.rjw@sisk.pl> (raw)
In-Reply-To: <4E85ADB7.1030900@gmail.com>

On Friday, September 30, 2011, xiaojiang wrote:
> On 2011?09?29? 20:18, MyungJoo Ham wrote:
> > +/**
> > + * find_device_devfreq() - find devfreq struct using device pointer
> > + * @dev:	device pointer used to lookup device devfreq.
> > + *
> > + * Search the list of device devfreqs and return the matched device's
> > + * devfreq info. devfreq_list_lock should be held by the caller.
> > + */
> > +static struct devfreq *find_device_devfreq(struct device *dev)
> > +{
> > +	struct devfreq *tmp_devfreq;
> > +
> > +	if (unlikely(IS_ERR_OR_NULL(dev))) {
> > +		pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
> > +		return ERR_PTR(-EINVAL);
> > +	}
> > +	WARN(!mutex_is_locked(&devfreq_list_lock),
> > +	     "devfreq_list_lock must be*loced*.");
> A typo, it should be locked.

Thanks, I'll fix it up.

Rafael

  parent reply	other threads:[~2011-09-30 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 12:18 [PATCH v13 0/4] Devfreq, DVFS Framework for Non-CPU Devices MyungJoo Ham
2011-09-29 12:18 ` [PATCH v13 1/4] PM / OPP: Add OPP availability change notifier MyungJoo Ham
2011-09-29 12:18 ` [PATCH v13 2/4] PM: Introduce devfreq: generic DVFS framework with device-specific OPPs MyungJoo Ham
     [not found]   ` <4E85ADB7.1030900@gmail.com>
2011-09-30 16:41     ` Rafael J. Wysocki [this message]
2011-09-29 12:18 ` [PATCH v13 3/4] PM / devfreq: add common sysfs interfaces MyungJoo Ham
2011-09-29 12:18 ` [PATCH v13 4/4] PM / devfreq: add basic governors MyungJoo Ham
2011-09-30 20:44 ` [PATCH v13 0/4] Devfreq, DVFS Framework for Non-CPU Devices Rafael J. Wysocki
2011-09-30 23:30   ` Kevin Hilman
2011-10-01 22:26     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109301841.41666.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ccross@google.com \
    --cc=gregkh@suse.de \
    --cc=jgq516@gmail.com \
    --cc=khilman@ti.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mturquette@ti.com \
    --cc=myungjoo.ham@gmail.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=nm@ti.com \
    --cc=pavel@ucw.cz \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome