From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013Ab1JCIvB (ORCPT ); Mon, 3 Oct 2011 04:51:01 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:38385 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413Ab1JCIuz (ORCPT ); Mon, 3 Oct 2011 04:50:55 -0400 Date: Mon, 3 Oct 2011 09:50:29 +0100 From: Russell King - ARM Linux To: Nicolas Ferre Cc: linux-arm-kernel@lists.infradead.org, alan@linux.intel.com, linux-serial@vger.kernel.org, plagnioj@jcrosoft.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function Message-ID: <20111003085029.GA11710@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 03, 2011 at 11:46:16AM +0200, Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre > --- > drivers/tty/serial/atmel_serial.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index a652f8f..453cdb5 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1789,7 +1789,7 @@ static int __devexit atmel_serial_remove(struct platform_device *pdev) > } > > static struct platform_driver atmel_serial_driver = { > - .probe = atmel_serial_probe, > + .probe = __devexit_p(atmel_serial_probe), That doesn't match the patch description (and is probably wrong.)