From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755695Ab1JCMZP (ORCPT ); Mon, 3 Oct 2011 08:25:15 -0400 Received: from shutemov.name ([188.40.19.243]:58502 "EHLO shutemov.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810Ab1JCMZM (ORCPT ); Mon, 3 Oct 2011 08:25:12 -0400 Date: Mon, 3 Oct 2011 15:25:11 +0300 From: "Kirill A. Shutemov" To: Glauber Costa Cc: linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, avagin@parallels.com Subject: Re: [PATCH v4 7/8] Display current tcp memory allocation in kmem cgroup Message-ID: <20111003122511.GA29982@shutemov.name> References: <1317637123-18306-1-git-send-email-glommer@parallels.com> <1317637123-18306-8-git-send-email-glommer@parallels.com> <20111003121446.GD29312@shutemov.name> <4E89A846.1010200@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E89A846.1010200@parallels.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 03, 2011 at 04:19:18PM +0400, Glauber Costa wrote: > On 10/03/2011 04:14 PM, Kirill A. Shutemov wrote: > > On Mon, Oct 03, 2011 at 02:18:42PM +0400, Glauber Costa wrote: > >> This patch introduces kmem.tcp_current_memory file, living in the > >> kmem_cgroup filesystem. It is a simple read-only file that displays the > >> amount of kernel memory currently consumed by the cgroup. > >> > >> Signed-off-by: Glauber Costa > >> CC: David S. Miller > >> CC: Hiroyouki Kamezawa > >> CC: Eric W. Biederman > >> --- > >> Documentation/cgroups/memory.txt | 1 + > >> mm/memcontrol.c | 11 +++++++++++ > >> 2 files changed, 12 insertions(+), 0 deletions(-) > >> > >> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt > >> index 1ffde3e..f5a539d 100644 > >> --- a/Documentation/cgroups/memory.txt > >> +++ b/Documentation/cgroups/memory.txt > >> @@ -79,6 +79,7 @@ Brief summary of control files. > >> memory.independent_kmem_limit # select whether or not kernel memory limits are > >> independent of user limits > >> memory.kmem.tcp.max_memory # set/show hard limit for tcp buf memory > >> + memory.kmem.tcp.current_memory # show current tcp buf memory allocation > > > > Both are in pages, right? > > Shouldn't it be scaled to bytes and named uniform with other memcg file? > > memory.kmem.tcp.limit_in_bytes/usage_in_bytes. > > > You are absolutely correct. > Since the internal tcp comparison works, I just ended up never noticing > this. Should we have failcnt and max_usage_in_bytes for tcp as well? -- Kirill A. Shutemov