From: Oleg Nesterov <oleg@redhat.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC][PATCH 0/5] Signal scalability series
Date: Tue, 4 Oct 2011 19:29:38 +0200 [thread overview]
Message-ID: <20111004172938.GB3489@redhat.com> (raw)
In-Reply-To: <1317718577.3375.103.camel@mfleming-mobl1.ger.corp.intel.com>
On 10/04, Matt Fleming wrote:
>
> Ah, I think it was these lines that confused me into thinking
> ->ctrl_lock wasn't required around PF_EXITING,
>
> void exit_signals(struct task_struct *tsk)
> {
> int group_stop = 0;
> sigset_t unblocked;
>
> if (thread_group_empty(tsk) || signal_group_exit(tsk->signal)) {
> tsk->flags |= PF_EXITING;
> return;
> }
>
> But I guess that's safe because either we're the only thread in the
> group or the group is already going to exit?
Yes. Except s/exit/exit or exec/.
And this reminds me... This is not exactly right. I do not mean
this particular function, but the whole logic. An execing process
can miss SIGSTOP. Or the coredumping signal.
Oleg.
next prev parent reply other threads:[~2011-10-04 17:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 15:12 Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 1/5] signal: Document signal locking rules Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 2/5] signal: Add rwlock to protect sighand->action Matt Fleming
2011-09-30 15:25 ` Peter Zijlstra
2011-09-30 15:56 ` Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 3/5] signal: Reduce sighand->siglock hold time in get_signal_to_deliver() Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 4/5] signal: Add signal->ctrl_lock for job control Matt Fleming
2011-09-30 15:30 ` Peter Zijlstra
2011-09-30 15:36 ` Matt Fleming
2011-09-30 15:12 ` [RFC][PATCH 5/5] signal: Split siglock into shared_siglock and per-thread siglock Matt Fleming
2011-09-30 16:52 ` [RFC][PATCH 0/5] Signal scalability series Oleg Nesterov
2011-09-30 18:54 ` Oleg Nesterov
2011-09-30 20:00 ` Matt Fleming
2011-09-30 23:56 ` Tejun Heo
2011-10-01 10:16 ` Matt Fleming
2011-10-01 13:03 ` Peter Zijlstra
2011-10-03 1:38 ` Tejun Heo
2011-10-03 13:56 ` Thomas Gleixner
2011-10-04 7:37 ` Tejun Heo
2011-10-03 13:07 ` Oleg Nesterov
2011-10-03 15:22 ` Peter Zijlstra
2011-10-04 17:14 ` Oleg Nesterov
2011-10-04 17:52 ` Oleg Nesterov
2011-10-04 17:54 ` Linus Torvalds
2011-10-04 18:13 ` Oleg Nesterov
2011-10-03 13:16 ` Oleg Nesterov
2011-10-04 8:56 ` Matt Fleming
2011-10-04 17:29 ` Oleg Nesterov [this message]
2011-09-30 22:30 ` Andi Kleen
2011-10-01 9:35 ` Matt Fleming
2011-10-03 15:28 ` Linus Torvalds
2011-10-03 15:43 ` Matt Fleming
2011-10-03 16:35 ` Oleg Nesterov
2011-10-03 20:58 ` Matt Fleming
2011-10-03 21:45 ` Linus Torvalds
2011-10-03 22:13 ` Thomas Gleixner
2011-10-04 8:20 ` Matt Fleming
2011-10-04 17:39 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004172938.GB3489@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome