From: Jan Kara <jack@suse.cz>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, jack@suse.cz,
akpm@linux-foundation.org, adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static
Date: Wed, 5 Oct 2011 01:37:46 +0200 [thread overview]
Message-ID: <20111004233746.GC21205@quack.suse.cz> (raw)
In-Reply-To: <201109231507.09998.hartleys@visionengravers.com>
On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.
Honza
>
> ---
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3c218b8..3f065f8 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-10-04 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 22:07 H Hartley Sweeten
2011-10-04 23:37 ` Jan Kara [this message]
2011-10-05 17:27 ` H Hartley Sweeten
2011-10-05 20:18 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004233746.GC21205@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®