From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933535Ab1JDW20 (ORCPT ); Tue, 4 Oct 2011 18:28:26 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:48045 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933180Ab1JDW2Z (ORCPT ); Tue, 4 Oct 2011 18:28:25 -0400 From: "Rafael J. Wysocki" To: Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH] PM: HIBERNATION: add resume_wait param to support MMC-like devices as resume file Date: Wed, 5 Oct 2011 00:30:43 +0200 User-Agent: KMail/1.13.6 (Linux/3.1.0-rc8+; KDE/4.6.0; x86_64; ; ) Cc: Valdis.Kletnieks@vt.edu, Barry Song , frank.hofmann@tomtom.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, workgroup.linux@csr.com, pavel@ucw.cz, Barry Song , linux-pm@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org References: <1317288548-19560-1-git-send-email-Barry.Song@csr.com> <59872.1317299401@turing-police.cc.vt.edu> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201110050030.43953.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 29, 2011, Barry Song wrote: > hi Valdis, > > 2011/9/29 : > > On Thu, 29 Sep 2011 02:29:08 PDT, Barry Song said: > > > >> This patch adds resumewait kernel param just like rootwait so > >> that we have enough time to wait mmc ready. The differene is > >> here we wait for resume partition but rootwait waits for rootfs > >> partition. > > > > OK, seems a reasonable idea... > > > >> kernel/power/hibernate.c | 16 ++++++++++++++++ > >> 1 files changed, 16 insertions(+), 0 deletions(-) > > > > We have a __setup() parameter, this patch appears to be missing > > a hunk for Documentation/kernel-parameters.txt? > > > > Fix that issue, and you can stick this on there: > > > > Reviewed-by: Valdis Kletnieks > > thanks. i'll add the document in v2. I can't find the v2. Have you posted it already? Rafael