mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Thomas Tuttle <ttuttle@chromium.org>
Cc: linux-kernel@vger.kernel.org, Johan Myreen <jem@iki.fi>
Subject: Re: [PATCH] misc/serio_raw: Avoid circular locking.
Date: Wed, 5 Oct 2011 22:07:26 -0700	[thread overview]
Message-ID: <20111006050725.GD20217@core.coreip.homeip.net> (raw)
In-Reply-To: <20111005170249.GA27129@google.com>

Hi Thomas,

On Wed, Oct 05, 2011 at 01:02:49PM -0400, Thomas Tuttle wrote:
> 
> This patch rearranges serio_raw_connect so that it takes the mutex once
> to allocate a device number and open the serio device, drops it to call
> misc_register, then takes it again to add the serio_raw device to the
> list.
> 
> BUG=chromium-os:21113
> TEST=Adhoc: PROVE_LOCKING no longer finds circular locking dependency
> 
> Change-Id: I414c5a3d606c28c81e42dcf989e5c55918eb4ea3
> Signed-off-by: Thomas Tuttle <ttuttle@chromium.org>
> ---
> I think this works, but I'm not familiar enough with the misc and serio
> subsystems to know if this is completely correct, nor if it is the best
> way to break the circular dependency.  Feedback would be appreciated.

Thank you for your report; I looked at the driver and (to my
embarrassment) is is quite broken and requires a bit more extensive
fixing. I'll be posting a few patches shortly and would appreciate if
you could look them over and/or test.

Thanks.

-- 
Dmitry

      reply	other threads:[~2011-10-06  5:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 17:02 Thomas Tuttle
2011-10-06  5:07 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111006050725.GD20217@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=jem@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ttuttle@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®