From: Tejun Heo <tj@kernel.org>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Borislav Petkov <bp@amd64.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Borislav Petkov <bp@alien8.de>,
"tigran@aivazian.fsnet.co.uk" <tigran@aivazian.fsnet.co.uk>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@elte.hu" <mingo@elte.hu>, "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [BUGFIX][PATCH RESEND] Freezer, CPU hotplug, x86 Microcode: Fix task freezing failures
Date: Thu, 6 Oct 2011 15:13:34 -0700 [thread overview]
Message-ID: <20111006221334.GB7085@google.com> (raw)
In-Reply-To: <4E8E1125.4050701@linux.vnet.ibm.com>
Hello,
On Fri, Oct 07, 2011 at 02:05:49AM +0530, Srivatsa S. Bhat wrote:
...
> diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
> index f924280..cd7ef2f 100644
> --- a/arch/x86/kernel/microcode_core.c
> +++ b/arch/x86/kernel/microcode_core.c
> @@ -483,7 +483,15 @@ mc_cpu_callback(struct notifier_block *nb, unsigned long action, void *hcpu)
> sysfs_remove_group(&sys_dev->kobj, &mc_attr_group);
> pr_debug("CPU%d removed\n", cpu);
> break;
> - case CPU_DEAD:
> +
> + /*
> + * Do not invalidate the microcode if a CPU goes offline,
> + * because it would be impossible to get the microcode again
> + * from userspace when the CPU comes back up, if the userspace
> + * happens to be frozen at that moment by the freezer subsystem,
> + * for example, due to a suspend operation in progress.
> + */
> +
This still looks like a bandaid to me. The exclusion approach didn't
pan out?
Thank you.
--
tejun
next prev parent reply other threads:[~2011-10-06 22:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 19:05 [BUGFIX][PATCH] " Srivatsa S. Bhat
2011-10-02 19:36 ` Rafael J. Wysocki
2011-10-02 19:50 ` Tejun Heo
2011-10-02 20:04 ` Srivatsa S. Bhat
2011-10-03 0:40 ` Tejun Heo
2011-10-03 5:51 ` Srivatsa S. Bhat
2011-10-03 8:47 ` Borislav Petkov
2011-10-04 7:15 ` Tejun Heo
2011-10-04 13:15 ` Srivatsa S. Bhat
2011-10-04 13:46 ` Borislav Petkov
2011-10-04 17:14 ` Borislav Petkov
2011-10-04 19:49 ` Rafael J. Wysocki
2011-10-04 20:57 ` Srivatsa S. Bhat
2011-10-05 7:21 ` Borislav Petkov
2011-10-05 8:51 ` Srivatsa S. Bhat
2011-10-05 20:26 ` Rafael J. Wysocki
2011-10-05 21:15 ` Srivatsa S. Bhat
2011-10-05 22:43 ` Rafael J. Wysocki
2011-10-06 6:50 ` Srivatsa S. Bhat
2011-10-06 8:34 ` Borislav Petkov
2011-10-06 15:47 ` Srivatsa S. Bhat
2011-10-06 18:11 ` Srivatsa S. Bhat
2011-10-06 20:35 ` [BUGFIX][PATCH RESEND] " Srivatsa S. Bhat
2011-10-06 22:13 ` Tejun Heo [this message]
2011-10-06 22:34 ` Borislav Petkov
2011-10-07 16:48 ` Srivatsa S. Bhat
2011-10-07 18:05 ` Borislav Petkov
2011-10-04 13:25 ` [BUGFIX][PATCH] " Borislav Petkov
2011-10-05 8:33 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006221334.GB7085@google.com \
--to=tj@kernel.org \
--cc=bp@alien8.de \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome