From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754107Ab1JGTS7 (ORCPT ); Fri, 7 Oct 2011 15:18:59 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:60804 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281Ab1JGTS4 (ORCPT ); Fri, 7 Oct 2011 15:18:56 -0400 Date: Fri, 7 Oct 2011 20:18:22 +0100 From: Russell King - ARM Linux To: Joe Perches Cc: =?iso-8859-1?Q?V=EDctor_Manuel_J=E1quez?= Leal , Tony Lindgren , linux-kernel@vger.kernel.org, Timo Teras , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] omap: dmtimer: convert printk to pr_err Message-ID: <20111007191822.GA26805@n2100.arm.linux.org.uk> References: <20111006201827.GT6324@atomide.com> <1317977417-17874-1-git-send-email-vjaquez@igalia.com> <20111007092243.GC27281@n2100.arm.linux.org.uk> <1318009239.1644.38.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1318009239.1644.38.camel@Joe-Laptop> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote: > At some point in the next couple of years, I want > to convert all of, or as many as possible of, the > remaining printk uses to pr_. If the idea is also to get rid of printk() too (which IMHO would be a good thing as it kills off the constant need to continually patch for missing KERN_ prefixes) then that's a good reason (provided Linus accepts the idea.) At that point having such patches as part of a progressive series of patches also makes sense. Doing it piecemeal when we've already had frequent complaints from Linus about useless churn with no apparant reasoning behind it doesn't help relieve us of those accusations.