mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: "Víctor Manuel Jáquez Leal" <vjaquez@igalia.com>,
	"Tony Lindgren" <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	"Timo Teras" <timo.teras@solidboot.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] omap: dmtimer: convert printk to pr_err
Date: Fri, 7 Oct 2011 20:57:14 +0100	[thread overview]
Message-ID: <20111007195714.GB26805@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1318016901.11045.9.camel@Joe-Laptop>

On Fri, Oct 07, 2011 at 12:48:21PM -0700, Joe Perches wrote:
> On Fri, 2011-10-07 at 20:18 +0100, Russell King - ARM Linux wrote:
> > On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote:
> > > At some point in the next couple of years, I want
> > > to convert all of, or as many as possible of, the
> > > remaining printk uses to pr_<level>.
> > If the idea is also to get rid of printk() too (which IMHO would be a
> > good thing as it kills off the constant need to continually patch for
> > missing KERN_ prefixes) then that's a good reason (provided Linus
> > accepts the idea.)
> 
> I don't accept that idea yet.
> 
> There are about 50K printks vs 20K pr_<level>s
> in kernel source.
> 
> I think 50K lines is _way_ too many to convert
> in a couple of years.
> 
> I think it needs to be done subsystem by subsystem,
> arch by arch, as maintainers accept.

Agreed - but doing one instance here, maybe another instance somewhere
else, and come the merge window having several of these patches
scattered around with no real coherent "this is what we're doing, and
its all done for this bit of the tree" kind of story is not the way to
do it.

It would be good to get core code done, or a sub-arch, and then say
"we're not accepting any patch which re-introduces the problem"...
It's a little late in the cycle for that now though.

  reply	other threads:[~2011-10-07 19:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 10:48 [PATCH] omap: dmtimer: convert printk to pr_* Víctor Manuel Jáquez Leal
2011-10-06 15:19 ` Joe Perches
2011-10-06 16:26   ` Víctor M. Jáquez L.
2011-10-06 17:30 ` [PATCH v2] omap: dmtimer: convert printk to pr_err / WARN Víctor Manuel Jáquez Leal
2011-10-06 20:18   ` Tony Lindgren
2011-10-07  8:50     ` [PATCH v3] omap: dmtimer: convert printk to pr_err Víctor Manuel Jáquez Leal
2011-10-07  9:22       ` Russell King - ARM Linux
2011-10-07 10:46         ` Víctor M. Jáquez L.
2011-10-07 17:40         ` Joe Perches
2011-10-07 19:18           ` Russell King - ARM Linux
2011-10-07 19:48             ` Joe Perches
2011-10-07 19:57               ` Russell King - ARM Linux [this message]
2011-10-07 20:02                 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111007195714.GB26805@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=timo.teras@solidboot.com \
    --cc=tony@atomide.com \
    --cc=vjaquez@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®