From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linville@tuxdriver.com, davem@davemloft.net
Subject: Re: et131x: Moving the et131x driver out of staging? (a.k.a. filling up the TODO list again)
Date: Sat, 8 Oct 2011 02:56:45 +0300 [thread overview]
Message-ID: <20111007235644.GK18470@longonot.mountain> (raw)
In-Reply-To: <CANK3SE398D+DiXLWDystz_jSpD4WJaLqt9gCmVstr+8TginDRw@mail.gmail.com>
There are some trivial static checker things that could be cleaned
up.
drivers/staging/et131x/et131x_initpci.c +489 et131x_adjust_link(45) error: we previously assumed 'phydev' could be null (see line 475)
drivers/staging/et131x/et131x_initpci.c +505 et131x_adjust_link(61) warn: variable dereferenced before check 'phydev' (see line 498)
(probably the null check should be removed?)
drivers/staging/et131x/et1310_mac.c:376:44: warning: incorrect type in initializer (different address spaces)
drivers/staging/et131x/et1310_mac.c:376:44: expected struct txmac_regs *txmac
drivers/staging/et131x/et1310_mac.c:376:44: got struct txmac_regs [noderef] <asn:2>*<noident>
drivers/staging/et131x/et1310_mac.c:383:28: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/et131x/et1310_mac.c:383:28: expected void volatile [noderef] <asn:2>*addr
drivers/staging/et131x/et1310_mac.c:383:28: got unsigned int *<noident>
drivers/staging/et131x/et1310_mac.c:385:31: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/et131x/et1310_mac.c:385:31: expected void volatile [noderef] <asn:2>*addr
drivers/staging/et131x/et1310_mac.c:385:31: got unsigned int *<noident>
(it just needs an __iomem anotation).
drivers/staging/et131x/et131x_initpci.c:556:5: warning: symbol 'et131x_mii_probe' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:246:5: warning: symbol 'et131x_ioctl' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:264:5: warning: symbol 'et131x_set_packet_filter' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:326:6: warning: symbol 'et131x_multicast' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:399:5: warning: symbol 'et131x_tx' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:432:6: warning: symbol 'et131x_tx_timeout' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:490:5: warning: symbol 'et131x_change_mtu' was not declared. Should it be static?
drivers/staging/et131x/et131x_netdev.c:543:5: warning: symbol 'et131x_set_mac_addr' was not declared. Should it be static?
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-07 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:07 Mark Einon
2011-10-07 23:28 ` Francois Romieu
2011-10-07 23:56 ` Dan Carpenter [this message]
2011-10-08 15:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007235644.GK18470@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mark.einon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®