From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218Ab1JJHAe (ORCPT ); Mon, 10 Oct 2011 03:00:34 -0400 Received: from mail.skyhub.de ([78.46.96.112]:50396 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659Ab1JJHAc (ORCPT ); Mon, 10 Oct 2011 03:00:32 -0400 Date: Mon, 10 Oct 2011 09:00:28 +0200 From: Borislav Petkov To: Barry Song <21cnbao@gmail.com> Cc: Barry Song , pavel@ucw.cz, rjw@sisk.pl, linux-pm@lists.linux-foundation.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, workgroup.linux@csr.com, Barry Song Subject: Re: [PATCH] PM: HIBERNATION: add resume_delay kernel param as well as resume_delay Message-ID: <20111010070028.GA11577@liondog.tnic> Mail-Followup-To: Borislav Petkov , Barry Song <21cnbao@gmail.com>, Barry Song , pavel@ucw.cz, rjw@sisk.pl, linux-pm@lists.linux-foundation.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, workgroup.linux@csr.com, Barry Song References: <1318225452-10397-1-git-send-email-Barry.Song@csr.com> <20111010062653.GB4139@liondog.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2011 at 02:34:45PM +0800, Barry Song wrote: > >> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c > >> index b3da53c..f73a00e 100644 > >> --- a/kernel/power/hibernate.c > >> +++ b/kernel/power/hibernate.c > >> @@ -33,6 +33,7 @@ > >>  static int nocompress = 0; > >>  static int noresume = 0; > >>  static int resume_wait = 0; > >> +static int resume_delay = 0; > > > > These static variables get zeroed needlessly and checkpatch actually > > warns about that. Maybe fix that up while you're there? > > yes. right. i initilized it to 0 to keep consistent coding style with > the context because there were other variants doing that. > i'd like to delete all initialization together as a seperate patch. Or > do you want to do that? Nah, you go ahead :-). Thanks. -- Regards/Gruss, Boris.