From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521Ab1JJQPV (ORCPT ); Mon, 10 Oct 2011 12:15:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45837 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897Ab1JJQPU (ORCPT ); Mon, 10 Oct 2011 12:15:20 -0400 Date: Mon, 10 Oct 2011 09:13:36 -0700 From: Greg KH To: Pelle Windestam Cc: Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings Message-ID: <20111010161336.GB23072@suse.de> References: <1318225337-25438-1-git-send-email-pelle@windestam.se> <20111010075250.GY18470@longonot.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2011 at 05:14:27PM +0200, Pelle Windestam wrote: > On Mon, Oct 10, 2011 at 9:52 AM, Dan Carpenter wrote: > > > This looked nicer in the original version.  I know that checkpatch > > complains but in the end, checkpatch is just a perl script.  It's > > less sentient than a squirrel. > > > > regards, > > dan carpenter > > > > I have to agree with you on that, but I wasn't sure how strictly to > follow the checkpatch warnings. I'll happily resubmit the patch > without this change if nobody minds. Please do.