From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753015Ab1JJQmB (ORCPT ); Mon, 10 Oct 2011 12:42:01 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47340 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751928Ab1JJQmA (ORCPT ); Mon, 10 Oct 2011 12:42:00 -0400 Date: Mon, 10 Oct 2011 18:41:57 +0200 From: Jan Kara To: Joe Perches Cc: Jan Kara , NamJae Jeon , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] udf: Convert printks to pr_ Message-ID: <20111010164157.GH3944@quack.suse.cz> References: <2eb3e996c9fd511f4c3dbf6f26efa3481b70a87a.1318233879.git.joe@perches.com> <20111010145953.GC3944@quack.suse.cz> <1318260214.25811.14.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1318260214.25811.14.camel@Joe-Laptop> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 10-10-11 08:23:34, Joe Perches wrote: > On Mon, 2011-10-10 at 16:59 +0200, Jan Kara wrote: > > On Mon 10-10-11 01:08:05, Joe Perches wrote: > > > Use the current logging styles. > > > > > > Convert a few printks that should have been udf_warn and udf_err. > > > Coalesce formats. Add #define pr_fmt. > > > Move an #include "udfdecls.h" above other includes in udftime.c > > > so pr_fmt works correctly. Strip prefixes from conversions as appropriate. > > > Reorder logging definitions in udfdecl.h > > Any reason why you didn't use udf_err() / udf_warn() in all the places > > where sb pointer is available? > > Oh, I forgot to mention that udf_err emits at KERN_CRIT. > I think that's not good. > > It's either an error or it's a critical notification > and the pr_crit should be pr_err or the function should > be renamed. Yeah, good point. I've changed udf_err() to call pr_err() because KERN_CRIT is really too much. Honza -- Jan Kara SUSE Labs, CR