From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303Ab1JKKNO (ORCPT ); Tue, 11 Oct 2011 06:13:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991Ab1JKKNM (ORCPT ); Tue, 11 Oct 2011 06:13:12 -0400 Date: Tue, 11 Oct 2011 06:12:21 -0400 From: Jeff Layton To: Pavel Machek Cc: trond.myklebust@netapp.com, smfrench@gmail.com, rjw@sisk.pl, linux-pm@lists.linux-foundation.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, john@Calva.COM, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] sunrpc: make rpc_wait_bit_killable handle freeze events Message-ID: <20111011061221.2a4a212f@tlielax.poochiereds.net> In-Reply-To: <20111011061923.GC1377@ucw.cz> References: <1317210761-11518-1-git-send-email-jlayton@redhat.com> <1317210761-11518-4-git-send-email-jlayton@redhat.com> <20111011061923.GC1377@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Oct 2011 08:19:23 +0200 Pavel Machek wrote: > On Wed 2011-09-28 07:52:40, Jeff Layton wrote: > > Allow the wait_on_bit_killable sleeps in SUNRPC layer to respect the > > freezer. This should allow suspend and hibernate events to occur, even > > when there are RPC's pending on the wire. > > Will the RPC protocols used handle that correctly? What will happen > during resume? > That depends on the state of the socket during resume. If the suspend/resume is quick enough, then the socket may still be connected, or if we're using UDP then we might just get the reply and carry on successfully. Otherwise, the call will eventually time out, or will be cancelled when the kernel finds that the socket has been closed. Either way, this should do the right thing. -- Jeff Layton