From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407Ab1JLLDm (ORCPT ); Wed, 12 Oct 2011 07:03:42 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:58754 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751179Ab1JLLDk (ORCPT ); Wed, 12 Oct 2011 07:03:40 -0400 Date: Wed, 12 Oct 2011 12:03:05 +0100 From: Alan Cox To: Sergei Shtylyov Cc: Bartlomiej Zolnierkiewicz , Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups Message-ID: <20111012120305.0b5f8f06@lxorguk.ukuu.org.uk> In-Reply-To: <4E957080.6020102@mvista.com> References: <201110112021.51236.bzolnier@gmail.com> <4E957080.6020102@mvista.com> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.4; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > + /* This last case is _NOT_ ok */ > > + case 0x30: > > + printk(KERN_ERR "sil680: Clock disabled ?\n"); > > pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)? dev_ would be even better but that seems to be a separate thing. The existing patch is still a move in the right direction.