From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Doug Anderson <dianders@chromium.org>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Stephen Warren <swarren@nvidia.com>,
Olof Johansson <olof@lixom.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Allen Martin <AMartin@nvidia.com>,
Tom Warren <twarren@nvidia.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty/serial: Prevent drop of DCD on suspend for Tegra UARTs
Date: Wed, 12 Oct 2011 12:56:47 +0100 [thread overview]
Message-ID: <20111012125647.6b9ec66e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1318377943-24519-1-git-send-email-dianders@chromium.org>
> NOTE: If we have people that are using UARTA on a Tegra and need to
> control DTR, we'll need to either add a separate port type for UARTA
> or we'll need to add some tegra-specific code to detect whether the
> DTR needs to be left high.
I have two problems with this change
- It adds more special cases into the 8250.c core code
- It breaks the UARTA port (which is a regression so not acceptable for
upstream merging)
I think you should simply provide your platform with an appropriate
serial_in/serial_out method that does the needed masking. That way its
kept isolated from everyone else.
Alan
next prev parent reply other threads:[~2011-10-12 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 0:05 Doug Anderson
2011-10-12 11:56 ` Alan Cox [this message]
2011-10-13 17:57 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012125647.6b9ec66e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=AMartin@nvidia.com \
--cc=alan@linux.intel.com \
--cc=dianders@chromium.org \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=twarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®